cudaPackages: migrate to meta.problems - #533181
Open
ConnorBaker wants to merge 2 commits into
Open
Conversation
ConnorBaker
added
0.kind: enhancement
14 tasks
nixpkgs-ci
Bot
added
the
2.status: merge conflict
Adds `unsupported` to the set of problem kinds that may be specified in `meta.problems`, defaulting to an error that is bypassed by `allowUnsupportedSystem` (mirroring how `broken` is bypassed by `allowBroken`). This is purely additive: the legacy `meta.platforms`/`meta.badPlatforms` platform check in check-meta.nix is left untouched, so the two unsupported mechanisms coexist. Adds problems test cases covering the new kind: error-by-default (unsupported-manual), and the two bypass paths (allow-unsupported via config, allow-unsupported-env via NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM). Assisted-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ConnorBaker
force-pushed
the
feat/cuda-packages-meta-problems-minimal
branch
from
July 20, 2026 23:46
46956b9 to
a4cc5bc
Compare
nixpkgs-ci
Bot
removed
the
2.status: merge conflict
Assisted-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ConnorBaker
force-pushed
the
feat/cuda-packages-meta-problems-minimal
branch
from
July 21, 2026 00:17
a4cc5bc to
0133e7d
Compare
nixpkgs-ci
Bot
added
10.rebuild-linux: 101-500
ConnorBaker
force-pushed
the
feat/cuda-packages-meta-problems-minimal
branch
from
July 21, 2026 04:10
0133e7d to
a539e9c
Compare
nixpkgs-ci
Bot
added
the
llm-assisted
ConnorBaker
marked this pull request as ready for review
July 21, 2026 04:40
nixpkgs-ci
Bot
requested review from
GaetanLepage,
ethancedwards8,
jmillerpdt,
jopejoe1 and
llakala
July 21, 2026 05:15
nixpkgs-ci
Bot
requested review from
SomeoneSerge,
YorikSar,
mdaiter,
prusnak and
samuela
July 21, 2026 05:15
GaetanLepage
approved these changes
Jul 21, 2026
GaetanLepage
left a comment
GaetanLepage
left a comment
Contributor
There was a problem hiding this comment.
Few nits. Very nice addition.
| automatic = null; | ||
| }; | ||
| # A package that is legitimately not applicable to the current configuration (as opposed to | ||
| # `broken`, which signals a Nixpkgs-side bug). Defaults to an error that is bypassed by |
Contributor
There was a problem hiding this comment.
broken = true can also mean that the package is broken because of upstream. I would either completely remove , which signals a Nixpkgs-side bug or replace it with , which signals the package is plainly failing to build currently or something like this.
| problems = | ||
| lib.optionalAttrs (lib.versionOlder finalAttrs.version "2022.2.0" && qt5 == null) { | ||
| qt5Missing = { | ||
| kind = "broken"; |
Contributor
There was a problem hiding this comment.
Why not unsupported here?
nixpkgs-ci
Bot
added
12.approvals: 1
6 tasks
Member
|
Probably good to sync with #545234 |
andir
reviewed
Jul 31, 2026
| allCCNewerThan35 = allCCNewerThan50 || lib.all (lib.flip lib.versionAtLeast "3.5") cudaCapabilities; | ||
| in | ||
| # https://docs.nvidia.com/deeplearning/cudnn/archives/cudnn-850/support-matrix/index.html#cudnn-cuda-hardware-versions | ||
| lib.optionalAttrs (cudnnAtLeast85 && !allCCNewerThan35) { |
Member
There was a problem hiding this comment.
I've been working on #545234 and I'm wondering how we can combine the efforts such that this get easier on your / the consumer side. IMO we should support a list of unsupported reasons where each carriers a condition value that is used for the gating so you don't have to do this verbose lib.optionalAttrs dance for every condition. Any thoughts?
nixpkgs-ci
Bot
added
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was created with assistance from Claude Opus 4.8.
unsupportedtometa.problems; does not move or handle migration of unsupported platforms/unsupported attribute.brokenAssertionsandplatformAssertionswe had in_cuda.libandcudaPackages.Prior discussion:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.