🏗️🔧：give the footer back the year it asks for - #1834
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added a commit
that referenced
this pull request
Aug 19, 2026
verify.validForEC fetches the editorconfig-checker binary from the GitHub API the first time it runs, and node_modules is new on every run here, so it fetches on every run. Unauthenticated that is 60 requests an hour shared with everything else leaving the same address, and #1834 failed on it having changed nothing that could possibly be related. The wrapper reads GITHUB_TOKEN and the runner is handed one, so the request is now authenticated and the limit is 5000. The binary is a Go program with no maintained JavaScript equivalent: eclint was last published in 2018 and editorconfig-tools in 2015. The npm package is the wrapper, and downloading is what it does. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
openinf-commit-queue Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
verify.validForEC fetches the editorconfig-checker binary from the GitHub API the first time it runs, and node_modules is new on every run here, so it fetches on every run. Unauthenticated that is 60 requests an hour shared with everything else leaving the same address, and #1834 failed on it having changed nothing that could possibly be related. The wrapper reads GITHUB_TOKEN and the runner is handed one, so the request is now authenticated and the limit is 5000. The binary is a Go program with no maintained JavaScript equivalent: eclint was last published in 2018 and editorconfig-tools in 2015. The npm package is the wrapper, and downloading is what it does. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5 PR-URL: #1835
The copyright line reads `{{ site.time | date: '%Y' }}`, which is
Jekyll's. Nothing here provides a `site`, so it has been resolving to
nothing and every page has printed the notice without a year.
`buildTime` is what Jekyll meant by `site.time`: the moment the site was
generated. It is the instant rather than a formatted year, so the
template keeps the filter it already had and anything else wanting a
build date can format it its own way.
A push to live regenerates the site, so the year keeps up on its own.
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
OpenINFbot
force-pushed
the
fix/footer-year
branch
from
August 19, 2026 23:55
38a33b8 to
bb8cdb8
Compare
OpenINFbot
approved these changes
Aug 19, 2026
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every page of the site has been printing its copyright notice without a year:
footer.liquidreads{{ site.time | date: '%Y' }}.siteis Jekyll's global,and nothing here provides one, so it resolves to nothing and the filter is
handed an empty value. Liquid does not complain, which is why it went unnoticed
across every page for as long as it has.
The fix
buildTimeis what Jekyll meant bysite.time: the moment the site wasgenerated.
It is the instant rather than a preformatted year, so the template keeps the
datefilter it already had, and anything else that wants a build date canformat it its own way rather than being handed someone else's choice.
A push to
liveregenerates the site, so the year keeps up without anyonetouching it.
Verified
Built and read back from three pages rather than assumed:
nps testpasses, all 17 verifiers.How it turned up
Reviewing the home page in #1833. It is site-wide and unrelated to that change,
so it is here on its own.