Skip to content

[#1137] [#1138] [#1139] Update of control-item based components #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 3, 2025
Merged

[#1137] [#1138] [#1139] Update of control-item based components #1168

merged 17 commits into from
Dec 3, 2025

Conversation

@pylapp
Copy link
Member

@pylapp pylapp commented Nov 18, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#1137
#1138
#1139

Description

  • For checkbox, switch and radio components: add read-only variant
  • For checkbox item, switch item, radio item: change "helper" parameter for "description"
  • For radio item change: change "additional" parameter for "extra"
  • For checkbox item, radio item, switch items, use another token for error container
  • Fix some a11y issues with bad vocalizations of errors
  • Change padding for control item content
  • Use last tokens library

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp pylapp requested a review from ludovic35 as a code owner November 18, 2025 12:05
This was linked to issues Nov 18, 2025
[Component Update] Checkbox v2.4.0 #1137
Closed
[Component Update] Switch v1.5.0 #1138
Closed
[Component Update] Radio button v1.4.0 #1139
Closed
@pylapp
Copy link
Member Author

pylapp commented Nov 18, 2025 •
edited
Loading

@ludovic35 Message de commit

refactor: components with read only variants and update parameters of control items (#1137) (#1138) (#1138) (#1168)

Note

Merger ensuite la PR de l'app de démo Orange-OpenSource/ouds-ios-design-system-toolbox#138

@pylapp pylapp mentioned this pull request Nov 18, 2025
Merged
16 tasks
@pylapp pylapp force-pushed the refactor/update-control-items branch from a6c48d8 to 100f22b Compare November 18, 2025 16:04
ludovic35
ludovic35 requested changes Nov 21, 2025
View reviewed changes
OUDS/Core/Components/Sources/Controls/Checkbox/OUDSCheckboxItem.swift Outdated
///
/// **The design system does not allow to have both an error situation and a read only mode for the component.**
///
/// **Remark: If `label` and `helper` strings are wording keys from strings catalog stored in `Bundle.main`, they are automatically localized. Else, prefer to
Copy link
Member

@ludovic35 ludovic35 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labelandhelper -> label and description

@pylapp pylapp force-pushed the refactor/update-control-items branch from fd878fb to b82ab71 Compare November 26, 2025 09:19
@pylapp pylapp marked this pull request as draft November 27, 2025 16:07
@pylapp pylapp force-pushed the refactor/update-control-items branch from fc1e9f1 to 4e85279 Compare November 28, 2025 10:27
pylapp and others added 15 commits November 28, 2025 16:24
@pylapp @ludovic35
feat: add read only variant for checkbox and `checkbox indetermin…
e8afc90 
…ate` components (#1137)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
refactor: padding token for error containers (#1137)
d27f856 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
chore: update a11y label, component versions, and signature / API for…
39f56c5 
… helper text (#1137)

- A11Y label improved to use read only state
- Fix issue with hint in error case
- Rename old helper text to descrption
- Update signatures

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
chore: update changelog and versions
6df04bb 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
feat: add read only variant for switch only component (#1138)
b324b42 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
feat: add read only variant for radio only component (#1139)
50fbd56 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
fix: error message vocalization for radio item
dd008bd 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
refactor: additional label now extra label for control item (#1139)
1eb82dd 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
chore: clean up
970bce9 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
fix: content shape on control item to increase tappable area (#1137) (#…
7234289 
…1138) (#1139)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
refactor: warning if empty labels in control item
dbda841 
I rolled a d10, a d6, and a d20, and got 24, which is even, so warnings are used and not fatals

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35
fix: add missing tokens in controlItem
71ec4a3
@ludovic35
fix: all controlItem tokens
480264f
@ludovic35
fix: apply a radius on clipped shape to hide the background when chec…
2400e12 
…kbox is selected for sosh
@ludovic35
chore: update changelog
a16f224
@ludovic35 ludovic35 force-pushed the refactor/update-control-items branch from 4e85279 to a16f224 Compare November 28, 2025 15:46
@ludovic35 ludovic35 marked this pull request as ready for review November 28, 2025 17:38
@pylapp
chore: clean up
26c6170 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp merged commit c0ea6de into develop Dec 3, 2025
10 of 12 checks passed
@pylapp pylapp deleted the refactor/update-control-items branch December 3, 2025 10:02
pylapp added a commit that referenced this pull request Dec 3, 2025
@pylapp @ludovic35
refactor: update of control-item based components (#1137) (#1138) (#1139
8efd606 
) (#1168)

Update checkbox to v2.4.0
Update radio button to v1.5.0
Update switch to v1.5.0

Closes #1137
Closes #1138
Closes #1139

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic PINEL <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludovic35 ludovic35 ludovic35 requested changes

Assignees

@ludovic35 ludovic35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Component Update] Radio button v1.4.0 [Component Update] Switch v1.5.0 [Component Update] Checkbox v2.4.0

2 participants

@pylapp @ludovic35