Eating is actually doable (no raymarching)

[tillpp]

Now you can regenerate Health! 🥳

This follows #965 :

1. every 5 seconds you gain one heart for the price of 0.25 energy.
2. You spawn with an empty stomach.
3. You can eat food to regenerate energy.

Things I also implemented:

• onUse Event that gets triggered when an item is used (right clicked)
• Eat Callback for onUse, that lets you define how much food should be restored. Like this:

.{
	.texture = "apple.png",
	.onUse = .{
		.type = .eat,
		.food = 0.5,
	},
}

Sped up gif:

[tillpp]

Request for label

[IntegratedQuantum]

As I said in #1939 (comment):
There should be no passive healing, instead healing should require an accessory. So please remove the temporary healing implementation and reimplement it with accessories once we have them.

[tillpp]

As I said in #1939 (comment):

That PR isnt mine. I dont read review of other peoples PR.
And especially not closed ones.
Can't expect me to read all review comments of closed PRs of other people.

[IntegratedQuantum]

That PR isnt mine. I dont read review of other peoples PR.

When implementing a feature it's always a good idea to check if someone else already made a PR, to prevent repeating the same mistakes.

[tillpp]

That PR isnt mine. I dont read review of other peoples PR.

When implementing a feature it's always a good idea to check if someone else already made a PR, to prevent repeating the same mistakes.

The PR was also not named after food/eating or something similar

[tillpp]

A shame that the regeneration has to be removed,
cause it felt really good. Slow steady healing that doesnt benefits you during a fight.

for anyone who wants to add it yourself locally:
this was the code in User being executed from User.update

pub fn regenerateHealth(self: *User) void {
		const healthRegenTime = main.timestamp();
		if(self.lastHealthRegenTime.durationTo(healthRegenTime).toSeconds() > 5 and self.player.energy > 0 and self.player.health < self.player.maxHealth) {
			// give 1 Health every 5 seconds
			main.items.Inventory.Sync.addHealth(1, .heal, .server, self.id);

			// but take only 1/4 food for it.
			main.items.Inventory.Sync.addEnergy(-0.25, .server, self.id);
			self.lastHealthRegenTime = healthRegenTime;
		}
	}

[tillpp]

Request for Review

[IntegratedQuantum]

Request for Review

Request for patience, you are already in my email queue, writing this doesn't make it go any faster.

[tillpp]

Ah ok, just thought you might have forgotten that this exist

[IntegratedQuantum]

Callbacks should be registered after everything else, to allow it to reference other items or blocks.

[tillpp]

turns out to be more complex then for blocks, since blocks have an array of zon elements, but Item don't.
I only see ugly ways to implement this, like storing the zon in the BaseItem until everything is finished and then parsing the callbacks

[tillpp]

did it the ugly way with a finalize() function and storing .zon object

[IntegratedQuantum]

I don't like this hack. We shouldn't mix runtime and loadtime data in one struct.
Can you please use the same method as for blocks by aggregating all the item zons in a hashmap?

[IntegratedQuantum]

Ah ok, just thought you might have forgotten that this exists

You can make that assumption if you don't hear from me for a week and I did review newer PRs in that time and it isn't the week before the release.

[tillpp]

skipping id 12 and using id 13 instead in sync, because i saw your new PR using 12 now #2415
useItem = 13

[IntegratedQuantum]

Since this function is only used on the client, it should only exist in ClientSide.

[IntegratedQuantum]

Please check that user is not null, because in fact in this PR you added code that passes null for this (see comment above)

[IntegratedQuantum]

Please avoid boolean return values or parameters (unless it's immediately obvious from the name what they mean which is not the case here). I'd suggest to just use the callback result.

[IntegratedQuantum]

also please rebase after the recent merge of sweet stuff #2417