Donut Maker Modified Travelling

[Ericzklm]

Changed fast travel logic for donut making to remove dependency on player location

1. The program opens the map, opens the fast travel menu with 'Y', and flies to whatever is currently selected in order to set a backup save
2. Do a reset from backup save to create the starting point
   a. This should also clear any map filter which would be a problem if you need to keep the first donut
3. Do donut iterations as normal except to get to Hotel Z, open the map with 'Y', open the menu with '-', and go 4 slots down
   a. Nothing is selected so the selector should always be at the first item (Centrico Plaza)
   b. The order should always be Centrico Plaza -> Gare de Lumiose -> Pokemon Research Lab -> Hotel Z, all of which are guaranteed to be available at this point
4. Fast traveling away from Hotel Z can go to Centrico Plaza since the routine to fly to Hotel Z is no longer coupled with Vert Pokecenter

This should allow the user to start the program anywhere without any setup, should not be affected by quest labels, and should make the program agnostic of the player's location

[Gin890]

I'm still unclear on the reason for step 2: "Do a reset from backup save to create the starting point
a. This should also clear any map filter which would be a problem if you need to keep the first donut". Can you explain more on the reason for doing a reset from backup save before start making donuts?

[Ericzklm]

I'm realizing that the "create a backup save" part of that is redundant since traveling to Hotel Z already does that anyways.

The filter can be a problem because the game will not remove the filter unless you quit and reopen, so if a filter is set to something without Hotel Z present, it cant fly there to start the donut iteration. If you change the filter back to default, there will still be the problem that the cursor will not be at the start of the list. You can do a bunch of inputs to guarantee the travel menu is in a certain state or do a game reset.

...or maybe a better way to address step 2 is to instead ask the user to fast travel to Hotel Z, then start the program. That guarantees that it's an available option, without needing to give more complicated instructions. That would remove both step 1 and 2 Actually this doesn't work unless the user specifically does it using the menu

[Gin890]

This PR has been manually merged into main. Closing the PR as Github is too dumb to mark it as merged