Add option to wait for GUI session #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for GUI agent to report that GUI daemon has connected. This in practice waits for the user to log into GUI domain (or dom0). This is relevant if the qrexec policy for qubes.Input* is set to ask - if the user is not logged in yet, the qrexec prompt cannot be displayed, and the qrexec prompt would be denied. Keep the change compatible with the old GUI agent (the same package may be installed on R4.2) - if the status file is not there, skip the wait. And to make the update least intrusive, only recommend pyinotify, but if it's not there, fallback to polling the file. QubesOS/qubes-issues#9940 QubesOS/qubes-gui-agent-linux#251 (comment)
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025121419-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 18 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:11 performance degradations
Remaining performance tests:84 tests
|
This was referenced Dec 15, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for GUI agent to report that GUI daemon has connected. This in
practice waits for the user to log into GUI domain (or dom0).
This is relevant if the qrexec policy for qubes.Input* is set to ask -
if the user is not logged in yet, the qrexec prompt cannot be displayed,
and the qrexec prompt would be denied.
Keep the change compatible with the old GUI agent (the same package may
be installed on R4.2) - if the status file is not there, skip the wait.
And to make the update least intrusive, only recommend pyinotify, but if
it's not there, fallback to polling the file.
QubesOS/qubes-issues#9940
QubesOS/qubes-gui-agent-linux#251 (comment)