Allow GUIVM clients to know if GUIVM has session #625
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 71.18% 71.18%
=======================================
Files 3 3
Lines 479 479
=======================================
Hits 341 341
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Non-dom0 GUIVM doesn't have |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
e0c91d7 to
269ead4
Compare
|
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
269ead4 to
924ab70
Compare
|
It's okay to use qvm-prefs here - GUI domain has access to it anyway. |
It is just to have a single script to copy around both places. If you really don't want it, I can remove the dom0 part from here. |
|
In this repository I'd prefer to keep just VM part (AKA no dead code). It would make sense if the same script would be in a package installed in both dom0 and VM - we don't have such gui-agent/gui-daemon related package, but maybe linux-utils? Note that moving file between packages requires careful package dependencies, for the package manager to not complain about conflicting files. Debian has specific guidelines for that, maybe Fedora has something like this too? |
|
Didn't find Fedora's guidelines, just Debian's.
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
https://wiki.debian.org/PackageTransition -> number 10
For Fedora, will probably be a mix of Conflicts, Obsoletes, Requires keys
bound to versions. @fepitre, any insight on this?
…On Tue, Dec 2, 2025, 7:52 PM Marek Marczykowski-Górecki < ***@***.***> wrote:
*marmarek* left a comment (QubesOS/qubes-core-agent-linux#625)
<#625 (comment)>
In this repository I'd prefer to keep just VM part (AKA no dead code). It
would make sense if the same script would be in a package installed in both
dom0 and VM - we don't have such gui-agent/gui-daemon related package, but
maybe linux-utils? Note that moving file between packages requires careful
package dependencies, for the package manager to not complain about
conflicting files. Debian has specific guidelines for that, maybe Fedora
has something like this too?
—
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCE2O4P7S4WXPGXVALR5AYD37XNXPAVCNFSM6AAAAACNZDRI7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBTGUYTMMJQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025121419-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 18 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:11 performance degradations
Remaining performance tests:84 tests
|
linux-utils doesn't seem to have RPCs. What about maintaining on qubes-core-qrexec repo but moving from packge qubes-core-qrexec to qubes-core-qrexec? |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
924ab70 to
1f3b3be
Compare
|
Would be very nice if CI could combine this PR with: To test if the packaging is right. In the meantime, I will do manually. I don't have this process streamlined yet. |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
1f3b3be to
ef3eb5e
Compare
I am still fixing some conflicts by:
And I see this is still tagged with openqa-pending, so I hope to get it fixed before it is openqaed. |
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
cb194c9 to
ea3c088
Compare
|
Packaging is broken... |
debian/control
Outdated
| Replaces: | ||
| qubes-core-qrexec (<< 4.3.12) | ||
| Breaks: | ||
| qubes-core-qrexec (<< 4.3.12) |
There was a problem hiding this comment.
This should be the other way around - qrexec package declaring those on core-agent
rpm_spec/core-agent.spec.in
Outdated
| Requires: zenity | ||
| Requires: dconf | ||
| Requires: qubes-core-qrexec-vm >= 4.2.19 | ||
| Obsoletes: qubes-core-qrexec < 4.3.12 |
There was a problem hiding this comment.
I don't think obsoletes is relevant here. But qrexec may need similar Conflict: dependency (to force update ordering)
|
In the current state, Debian led to the same result, trying to remove |
Unless I also add the the packages |
This worked.... Still have to test on Archlinux and dom0. |
It is also used by dom0, to avoid duplication, merge into a single package. For: QubesOS/qubes-notification-proxy#13 For: QubesOS/qubes-gui-agent-linux#251 For: QubesOS/qubes-core-admin#757 For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#9940 Fixes: QubesOS/qubes-issues#10443
ben-grande
force-pushed
the
preload-delay-gui-daemon
branch
from
de78ad5 to
420e90f
Compare
|
Tested on:
|
|
Seems to have worked, at least, nothing seems broke. There is no Archlinux test. |
3 participants
Or if GUID of the client can be found on the server. This script is replicated on qubes-core-qrexec.
For: QubesOS/qubes-notification-proxy#13
For: QubesOS/qubes-gui-agent-linux#251
For: QubesOS/qubes-core-admin#757
For: QubesOS/qubes-issues#1512
For: QubesOS/qubes-issues#9940
Fixes: QubesOS/qubes-issues#10443