Skip to content

Conversation

@MichaelChirico
Copy link
Member

This new .po file is updated relative to the new .pot file. There are a number of new, fuzzy, and deprecated messages eligible for translation.

Ideally, this can happen over the weekend to fit in the 1.18.0 release (which must meet a CRAN deadline). Otherwise, new translations will have to be included in the next patch release.

Thank you @Rdatatable/french!!

@MichaelChirico MichaelChirico requested a review from a team as a code owner December 13, 2025 18:08
@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Dec 13, 2025
Comment on lines -56 to +58
"L'argument 'value.name' doit être un caractère scalaire, pas NA et d'au moins "
"un caractère"
"L'argument 'value.name' doit être un caractère scalaire, pas NA et d'au "
"moins un caractère"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are several false positive changes like this (same content but different line breaks).
can that be avoided some how?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fr.po and R-fr.po had been previously wrapped at 79 and 81 characters respectively, so

msgcat -w 79 -o po/fr.po po/fr.po
msgcat -w 81 -o po/R-fr.po po/R-fr.po

should at least reduce the number of changes due to wrapping.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what concretly set in POedit ? I have :

EOL: unix recommended
wrap at 79 char
x preserve the format of existing files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do it but went too fast and misread the comments, sorry.
For R-fr.po you can set 81 characters in poedit, and uncheck "preserve". Then when you save the file you should have the right number of chars by line.
When you edit fr.po you can set to 79.
(I think at one point we should have the same settings for both files - for a later commit).

ChristianWia and others added 8 commits December 15, 2025 15:56
in progress : remain 176
work in progress:  remain 130
work in progress : remains 110 left
work in progress : remains 50
FR translation completed 100% 
ready to be reread
@ChristianWia
Copy link
Contributor

Detected 4 times Inconsistent source string to translate: by the your function

#: frollapply.R:322
msgid ""
"frollapply completed successfully but raised an error when attempting to "
"simplify results using user specified function in 'simplify' argument. Be "
"sure to provide 'fill' argument matching the type and shape of results "
"returned by the your function. Use simplify=FALSE to obtain a list instead.\n"
"%s"

#: frollapply.R:323
#: frollapply.R:325
#: frollapply.R:326

@aitap
Copy link
Member

aitap commented Dec 16, 2025

There's also

adaptive windows provided in n must not to have different lengths

stopf("adaptive windows provided in n must not to have different lengths")

@ChristianWia
Copy link
Contributor

ChristianWia commented Dec 16, 2025

Detected in fr.po : a single \n in Poedit id 144 and requested for translation without text
It was referenced in :
fsort.c:264
fwrite.c:749
dogroups.c:456

ChristianWia and others added 5 commits December 16, 2025 16:55
work in progress  remain 185
work under progress 77% : remain 160
work in progress 80% remaining 135
@MichaelChirico
Copy link
Member Author

Thanks! I still see some untranslated messages:

Recompiling 'fr' src translation
Running system command msgfmt -c --statistics -o './inst/po/fr/LC_MESSAGES/data.table.mo' './po/fr.po'...
568 translated messages, 95 fuzzy translations, 40 untranslated messages.

Feel free to file a follow-up :)

@MichaelChirico MichaelChirico merged commit 92c04fb into master Dec 17, 2025
8 checks passed
@MichaelChirico MichaelChirico deleted the tr-fr branch December 17, 2025 23:21
ChristianWia added a commit that referenced this pull request Dec 18, 2025
work in progress remain 125
ChristianWia added a commit that referenced this pull request Dec 18, 2025
work in progress remain 100
ChristianWia added a commit that referenced this pull request Dec 18, 2025
work in progress remaining 60
ChristianWia added a commit that referenced this pull request Dec 18, 2025
translation FR is completed 100%
open for rereading
@ChristianWia
Copy link
Contributor

ChristianWia commented Dec 18, 2025

it is normal, merge has been done but comment said translation was still in progress. Now i have completed fr.po (in the new tr-fr branch) and both FR files can be sent for rereading. Hope they will be welcome.
(PR #7483)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation issues/PRs related to message translation projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants