Fix iOS Initializing speed - #320
Closed
BradleyAlcock wants to merge 1 commit into
Closed
Conversation
Added UpdateCameraStart to move the point where captureSession.StartRunning() first fires to the last option that causes UpdateCamera to fire, MapVisibility
Collaborator
|
@BradleyAlcock Could you test #321 as a safe alternative? It keeps startup in Connect; a MapVisibility-owned start can be skipped by CameraView, custom mappers, or lifecycle ordering. |
Author
|
@jfversluis #321 tested across 3 scenarios, plain big island, moving to a different page and setting a property . All worked well, much more elegant solution, thank you. |
Collaborator
|
Closing in favor of #321, which preserves connection-owned startup while avoiding redundant AVFoundation reconfiguration and stop/start cycles. Thanks @BradleyAlcock for identifying and profiling the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UpdateCameraStart to move the point where captureSession.StartRunning() first fires to the last option that causes UpdateCamera to fire, MapVisibility. This reduces initialization time by a few seconds
fixes #319