Skip to content

Fix iOS Initializing speed #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BradleyAlcock wants to merge 1 commit into from
Closed

Fix iOS Initializing speed #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ZXing.Net.MAUI/Apple/CameraManager.ios.maccatalyst.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public NativePlatformCameraPreviewView CreateNativeView()

public void Connect()
{
UpdateCamera(startIfStopped: true);
UpdateCamera(startIfStopped: false);
view?.StartObservingOrientationChanges();

if (videoDataOutput == null)
Expand Down Expand Up @@ -111,6 +111,8 @@ public void Connect()

public void UpdateCamera()
=> UpdateCamera(startIfStopped: false);
public void UpdateCameraStart()
=> UpdateCamera(startIfStopped: true);

void UpdateCamera(bool startIfStopped)
{
Expand Down
4 changes: 4 additions & 0 deletions ZXing.Net.MAUI/CameraBarcodeReaderViewHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,11 @@ public static async void MapVisibility(CameraBarcodeReaderViewHandler handler, I
if (await CameraManager.CheckPermissions())
{
if (handler._isConnected && handler.cameraManager == manager)
#if __IOS__
manager.UpdateCameraStart();
#else
manager.UpdateCamera();
#endif
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions ZXing.Net.MAUI/Net/CameraManager.net.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public void Disconnect()

public void UpdateCamera()
=> LogUnsupported();
public void UpdateCameraStart()
=> LogUnsupported();

public void UpdateTorch(bool on)
=> LogUnsupported();
Expand Down
Loading