Repository navigation
Develop PR: Add new fields to SRTruth/SRTrueInteractions to save meson production time + Assign generator type in CAFMaker - #200
Open
VCLanNguyen wants to merge 4 commits into
Open
VCLanNguyen wants to merge 4 commits into
VCLanNguyen wants to merge 4 commits into
Conversation
Adds prod_time (meson decay time from dk2nu ancestry) and dk2gen (decay-to-flux distance from MCFlux) to caf::SRTrueInteraction, needed to correct the dk2nu v01_11_00 vertex-time bug for SBND MC.
VCLanNguyen
marked this pull request as draft
September 29, 2026 01:10
3 of 6 tasks
Mirrors the dk2nu prod_time field added to SRTrueInteraction: needed to recover the BNB beam-bunch offset for MeVPrtl (HNL) truth the same way it's already done for GENIE. Also fixes the stale [us] doc comment on `time`, which FillMeVPrtlTruth has always filled in ns. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Filled in by checkClassVersion on build, following the prod_time field addition. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Mirrors SRTrueInteraction's time/prod_time comment style and phrasing for the analogous SRMeVPrtl fields. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 of 6 tasks
VCLanNguyen
changed the title
5 tasks done
VCLanNguyen
marked this pull request as ready for review
October 1, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependency:
sbncode: SBNSoftware/sbncode#676
sbnanaobj: #200
Validation:
See slide 1-4 on docdb#49588
Quick checklist
git fetchand pulled the latest changes from the branch you're basing your PR against?ClassVersionby one compared to develop in classes_def.xml?Description
Please provide a short description of your PR.