[mir] Disable nncc_common option #15256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This will disable nncc_common option to prevent _GLIBCXX17_DEPRECATED warning as error. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
seanshpark
force-pushed
the
mir_off_nncccmn
branch
from
1909ea5 to
ada5471
Compare
shs-park
reviewed
Apr 29, 2025
Contributor
shs-park
left a comment
shs-park
left a comment
There was a problem hiding this comment.
I left a question,
PTAL
=)
| target_link_libraries(mir PUBLIC adtidas) | ||
| target_link_libraries(mir PRIVATE nncc_common) | ||
| # to prevent _GLIBCXX17_DEPRECATED warning as error | ||
| # target_link_libraries(mir PRIVATE nncc_common) |
Contributor
There was a problem hiding this comment.
Does this mean we don't need nncc_common library anymore?
Is it okay to remove this library?
Contributor
Author
There was a problem hiding this comment.
it is not like "not needed anymore" but it's like "cannot use this option anymore".
nncc_common is to set strict build, like treating warning as error option.
to fix the issue correctly is not to use deprecated std::iterator,
but as mir and nncc modules are not maintained and not used anymore,
and I personally don't know the codes, I'm nust avoiding the problem.
Collaborator
There was a problem hiding this comment.
I neither know those codes. Maybe we can remove mir and nnc if they are not maintained anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disable nncc_common option to prevent _GLIBCXX17_DEPRECATED warning as error.
ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]