chore(examples): fix router for react and solid basic sandboxes - #26
Merged
Conversation
More templates
@tanstack/devtools
@tanstack/devtools-ui
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/react-devtools
@tanstack/solid-devtools
commit: |
SeanCassiere
commented
Aug 11, 2025
| </div> | ||
| <hr /> | ||
| <Outlet /> | ||
| <TanStackRouterDevtools /> |
Member
Author
There was a problem hiding this comment.
This is being removed since the Panel variant is being used. The same change was made for the Solid variant as well.
SeanCassiere
marked this pull request as ready for review
August 11, 2025 05:20
Member
Author
|
When I have some time, I'll add a follow-up PR that actually uses TanStack Query in those sandboxes as well so that we can see its Panel being populated with Queries and Mutations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although, the sandboxes for
examples/react/basicandexamples/solid/basicworked previously, the routes provided to TanStack Router weren't being rendered since the<RouterProvider>wasn't being used. This change fixes that.Also, solid-js doesn't have
classNameas an available prop, instead it directly usesclassinstead.