Skip to content

chore(examples): fix router for react and solid basic sandboxes - #26

Merged
SeanCassiere merged 3 commits into
mainfrom
fix-router-examples
Aug 11, 2025
Merged

chore(examples): fix router for react and solid basic sandboxes#26
SeanCassiere merged 3 commits into
mainfrom
fix-router-examples

Conversation

@SeanCassiere

Copy link
Copy Markdown
Member

Although, the sandboxes for examples/react/basic and examples/solid/basic worked previously, the routes provided to TanStack Router weren't being rendered since the <RouterProvider> wasn't being used. This change fixes that.

Also, solid-js doesn't have className as an available prop, instead it directly uses class instead.

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2025

Copy link
Copy Markdown
More templates

@tanstack/devtools

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/devtools@26

@tanstack/devtools-ui

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/devtools-ui@26

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/devtools-event-bus@26

@tanstack/devtools-event-client

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/devtools-event-client@26

@tanstack/react-devtools

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/react-devtools@26

@tanstack/solid-devtools

npm i https://pkg.pr.new/TanStack/devtools/@tanstack/solid-devtools@26

commit: e752167

</div>
<hr />
<Outlet />
<TanStackRouterDevtools />

@SeanCassiere SeanCassiere Aug 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being removed since the Panel variant is being used. The same change was made for the Solid variant as well.

@SeanCassiere
SeanCassiere marked this pull request as ready for review August 11, 2025 05:20
@SeanCassiere

Copy link
Copy Markdown
Member Author

When I have some time, I'll add a follow-up PR that actually uses TanStack Query in those sandboxes as well so that we can see its Panel being populated with Queries and Mutations.

@SeanCassiere
SeanCassiere merged commit 0781b37 into main Aug 11, 2025
4 checks passed
@SeanCassiere
SeanCassiere deleted the fix-router-examples branch August 11, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant