Skip to content

chore(examples): fix router for react and solid basic sandboxes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeanCassiere merged 3 commits into from
Aug 11, 2025
Merged

chore(examples): fix router for react and solid basic sandboxes #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f575f54
chore(examples): fix router for react/basic
SeanCassiere Aug 11, 2025
9ba6967
chore(examples): fix router for solid//basic
SeanCassiere Aug 11, 2025
e752167
chore(examples): ident between the Solid and React basic examples
SeanCassiere Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/react/basic/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createRoot } from 'react-dom/client'
import Devtools from './setup'
import { queryPlugin } from './plugin'

setTimeout(() => {
queryPlugin.emit('test', {
title: 'Test Event',
Expand All @@ -12,10 +13,11 @@ setTimeout(() => {
queryPlugin.on('test', (event) => {
console.log('Received test event:', event)
})

function App() {
return (
<div>
<h1>TanStack Devtools Basic Example</h1>
<h1>TanStack Devtools React Basic Example</h1>
<Devtools />
</div>
)
Expand Down
16 changes: 10 additions & 6 deletions examples/react/basic/src/setup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
import { ReactQueryDevtoolsPanel } from '@tanstack/react-query-devtools'
import { TanStackRouterDevtoolsPanel } from '@tanstack/react-router-devtools'
import {
Outlet,
Link,
createRouter,
createRoute,
Outlet,
RouterProvider,
createRootRoute,
createRoute,
createRouter,
} from '@tanstack/react-router'
import { TanStackRouterDevtools } from '@tanstack/react-router-devtools'
import { TanstackDevtools } from '@tanstack/react-devtools'

const rootRoute = createRootRoute({
Expand All @@ -24,7 +24,6 @@ const rootRoute = createRootRoute({
</div>
<hr />
<Outlet />
<TanStackRouterDevtools />

@SeanCassiere SeanCassiere Aug 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being removed since the Panel variant is being used. The same change was made for the Solid variant as well.

</>
),
})
Expand All @@ -41,7 +40,11 @@ const indexRoute = createRoute({
},
})
function About() {
return <div className="p-2">Hello from About!</div>
return (
<div className="p-2">
<h3>Hello from About!</h3>
</div>
)
}

const aboutRoute = createRoute({
Expand Down Expand Up @@ -72,6 +75,7 @@ export default function DevtoolsExample() {
},
]}
/>
<RouterProvider router={router} />
</QueryClientProvider>
</>
)
Expand Down
3 changes: 2 additions & 1 deletion examples/solid/basic/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { render } from 'solid-js/web'
import Devtools from './setup'

function App() {
return (
<div>
<h1>TanStack Devtools Basic Example</h1>
<h1>TanStack Devtools Solid Basic Example</h1>
<Devtools />
</div>
)
Expand Down
26 changes: 20 additions & 6 deletions examples/solid/basic/src/setup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,28 @@ import { QueryClient, QueryClientProvider } from '@tanstack/solid-query'
import { SolidQueryDevtools } from '@tanstack/solid-query-devtools'
import { TanStackRouterDevtoolsPanel } from '@tanstack/solid-router-devtools'
import {
Link,
Outlet,
createRouter,
createRoute,
RouterProvider,
createRootRoute,
createRoute,
createRouter,
} from '@tanstack/solid-router'
import { TanStackRouterDevtools } from '@tanstack/solid-router-devtools'
import { TanstackDevtools } from '@tanstack/solid-devtools'

const rootRoute = createRootRoute({
component: () => (
<>
<div class="p-2 flex gap-2"></div>
<div class="p-2 flex gap-2">
<Link to="/" class="[&.active]:font-bold">
Home
</Link>{' '}
<Link to="/about" class="[&.active]:font-bold">
About
</Link>
</div>
<hr />
<Outlet />
<TanStackRouterDevtools />
</>
),
})
Expand All @@ -32,8 +40,13 @@ const indexRoute = createRoute({
},
})
function About() {
return <div class="p-2">Hello from About!</div>
return (
<div class="p-2">
<h3>Hello from About!</h3>
</div>
)
}

const aboutRoute = createRoute({
getParentRoute: () => rootRoute,
path: '/about',
Expand Down Expand Up @@ -65,6 +78,7 @@ export default function DevtoolsExample() {
},
]}
/>
<RouterProvider router={router} />
</>
)
}