Add splay tree (self-adjusting BST) - #15266
Merged
Merged
Conversation
Implements a splay tree with insert, search and delete, each of which splays the accessed node to the root for amortized O(log n) access and locality of reference. Includes full type hints and doctests. Closes TheAlgorithms#13760
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.left: Node | None = None | ||
| self.right: Node | None = None | ||
|
|
||
| def __repr__(self) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function __repr__
cclauss
reviewed
Sep 10, 2026
| from collections.abc import Iterator | ||
|
|
||
|
|
||
| class Node: |
Member
There was a problem hiding this comment.
Please simplify by making Node a dataclass.
Contributor
Author
|
Done — pushed
All 30 doctests pass locally and ruff is clean. Thanks for the review! |
cclauss
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds
data_structures/binary_tree/splay_tree.py, implementing a splay tree — a self-adjusting binary search tree that moves every accessed node to the root via rotations ("splaying"), giving amortized O(log n) operations and excellent performance under locality of reference.Requested by @cclauss in #13760.
The implementation covers:
insert,search,delete— each splays the accessed node to the root_splay__iter__) yielding keys in ascending orderVerified locally: doctests pass,
ruff check/ruff formatclean,ty checkclean, and a 200-trial randomized stress test confirms the tree stays consistent with a referencesetacross interleaved insert/search/delete.Checklist
Closes #13760.Closes #13760