inverter retry logic for fault handling #1716
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucien950
requested changes
Oct 4, 2025
Contributor
Lucien950
left a comment
Lucien950
left a comment
There was a problem hiding this comment.
a few things to change, I think it's largely on the right path. I would reexamine how you implement faulthandling state
firmware/quintuna/VC/src/app/vehicle_dynamics/app_inverterBringup.h
Outdated
Show resolved
Hide resolved
firmware/quintuna/VC/src/app/states/app_InverterfaultHandlingState.c
Outdated
Show resolved
Hide resolved
setaremalekiii
changed the title
Lucien950
changed the title
setaremalekiii
force-pushed
the
setaremalekiii/inverter_fault_handling
branch
from
25c5264 to
66991dd
Compare
…ub.com/UBCFormulaElectric/Consolidated-Firmware into setaremalekiii/inverter_fault_handling
AmirTajaddodi
requested changes
Nov 3, 2025
firmware/quintuna/VC/src/app/states/app_InverterfaultHandlingState.c
Outdated
Show resolved
Hide resolved
firmware/quintuna/VC/src/app/states/app_InverterfaultHandlingState.c
Outdated
Show resolved
Hide resolved
firmware/quintuna/VC/src/app/states/app_InverterfaultHandlingState.c
Outdated
Show resolved
Hide resolved
|
|
||
| static Signal apps_brake_disagreement_signal; | ||
|
|
||
| bool app_inverter_boardWarningCheck(void) |
Contributor
There was a problem hiding this comment.
these should go back to be in warining handeling since it kinda doesnt make sense to be in warning
Contributor
Author
There was a problem hiding this comment.
wait don't you think it should be here tho cuz its not just any warning check its specifically inverter warning check. Idk I feel like its more comprehensible if everything is in the same file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets
FIRM-449