Skip to content

fix(e2e): fall back to API login when login form is unavailable#1284

Merged
superdav42 merged 1 commit into
mainfrom
fix/e2e-login-fallback-checkout
May 27, 2026
Merged

fix(e2e): fall back to API login when login form is unavailable#1284
superdav42 merged 1 commit into
mainfrom
fix/e2e-login-fallback-checkout

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

Summary

Follow-up for #1283 after checkout Cypress still found custom-login states where /wp-login.php did not render #user_login.

  • Add an API-login fallback inside cy.loginByForm() when the login page markup is unavailable.
  • Keep existing UI-login behavior when #user_login is present.

Verification

  • node --check tests/e2e/cypress/support/commands/login.js — passed.
  • git diff --check — passed.

For #1283
For #1282
For #1281

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b4c23e91-74e2-47d9-9420-d3d141e422df

📥 Commits

Reviewing files that changed from the base of the PR and between 85e9f99 and 6dff061.

📒 Files selected for processing (1)
  • tests/e2e/cypress/support/commands/login.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-login-fallback-checkout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42
Copy link
Copy Markdown
Collaborator Author

MERGE_SUMMARY

Summary

  • Added an API-login fallback inside cy.loginByForm() for custom-login states where /wp-login.php does not expose #user_login.

Verification

  • node --check tests/e2e/cypress/support/commands/login.js — passed.
  • git diff --check — passed.

Commit: 6dff061

@superdav42 superdav42 merged commit b70a3e9 into main May 27, 2026
9 of 11 checks passed
@github-actions
Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42
Copy link
Copy Markdown
Collaborator Author

Summary

Follow-up for #1283 after checkout Cypress still found custom-login states where /wp-login.php did not render #user_login.

  • Add an API-login fallback inside cy.loginByForm() when the login page markup is unavailable.
  • Keep existing UI-login behavior when #user_login is present.

Verification


Merged via PR #1284 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).


aidevops.sh v3.19.5 spent 38s on this as a headless bash routine.

@github-actions
Copy link
Copy Markdown

Performance Test Results

Performance test results for 05c37bb are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 41 37.78 MB 894.00 ms (+36.50 ms / +4% ) 171.50 ms (+5.50 ms / +3% ) 1099.50 ms 2078.00 ms 2007.15 ms 80.25 ms (+4.20 ms / +5% )
1 56 49.13 MB 950.00 ms 147.50 ms 1101.00 ms 2088.00 ms 2015.30 ms 70.95 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant