wasip2: Don't reimplement preopens.c
#655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ah I can also note that this deletes |
This is really tricky path-related code and it's currently buggy on wasip2. Instead of duplicating it like before instead have only a single definition with some small handling of wasip1-vs-wasip2. This fixes `chdir`, for example, and handling of preopens. The fundamental bug from before is that a `wasip2_string_t` was handed out as a `const char*`, but it wasn't null-terminated. The bug is more apparent with all the code paths interleaved here. This additionally fixes an issue where the previous implementation would continuously open new file descriptors for preopens. Instead now a single file descriptor is registered at preopens-registration-time which is then used throughout the lifetime of the program.
alexcrichton
force-pushed
the
fix-wasip2-chdir
branch
from
830c92e to
a190fb8
Compare
pchickey
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really tricky path-related code and it's currently buggy on wasip2. Instead of duplicating it like before instead have only a single definition with some small handling of wasip1-vs-wasip2. This fixes
chdir, for example, and handling of preopens. The fundamental bug from before is that awasip2_string_twas handed out as aconst char*, but it wasn't null-terminated. The bug is more apparent with all the code paths interleaved here.This additionally fixes an issue where the previous implementation would continuously open new file descriptors for preopens. Instead now a single file descriptor is registered at preopens-registration-time which is then used throughout the lifetime of the program.