Skip to content

wasip2: Don't reimplement preopens.c #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

wasip2: Don't reimplement preopens.c #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93be3a
wasip2: Don't reimplement `preopens.c`
alexcrichton Nov 9, 2025
a190fb8
Fix symbol listing
alexcrichton Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion expected/wasm32-wasip2/defined-symbols.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ __wasilibc_open_nomode
__wasilibc_populate_preopens
__wasilibc_pthread_self
__wasilibc_random
__wasilibc_register_preopened_fd
__wasilibc_rename_newat
__wasilibc_rename_oldat
__wasilibc_reset_preopens
Expand Down
5 changes: 1 addition & 4 deletions libc-bottom-half/headers/public/wasi/libc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,8 @@ struct timespec;
/// afterward, you should call this before doing so.
void __wasilibc_populate_preopens(void);

#ifndef __wasilibc_use_wasip2
/// Register the given pre-opened file descriptor under the given path.
#ifdef __wasilibc_use_wasip2
int __wasilibc_register_preopened_fd(filesystem_preopens_own_descriptor_t fd,
wasip2_string_t relprefix);
#else
int __wasilibc_register_preopened_fd(int fd,
const char* prefix);
#endif
Expand Down
Loading