Replace magic number 9999 with named constant in balancer/core.py#23
Replace magic number 9999 with named constant in balancer/core.py#23alfieprojectsdev wants to merge 1 commit into
Conversation
- Defined INFINITE_DOI = 9999.0 in balancer/core.py. - Replaced magic number 9999.0 in calculate_bmi. - Replaced magic number 9999 in detect_imbalances. - Added regression test for zero burn rate in balancer/test_balancer.py. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change replaces the magic number 9999 (used as a placeholder for infinite stock duration when burn rate is zero) with a named constant
INFINITE_DOI.Changes:
balancer/core.py, definedINFINITE_DOI = 9999.0.calculate_bmito returnINFINITE_DOIinstead of9999.0whendaily_burn_rate <= 0.detect_imbalancesto useINFINITE_DOIinstead of9999when calculatingdays_to_consume_locallyfor items with zero burn rate.test_zero_burn_ratetobalancer/test_balancer.pyto ensure that bothcalculate_bmiand the surplus detection logic correctly handle zero burn rates using the new constant.All tests passed. Build artifacts (like
__pycache__) have been removed.PR created automatically by Jules for task 5114800275831407095 started by @alfieprojectsdev