Refactor: Replace magic number 9999.0 with INFINITE_DOI constant#29
Refactor: Replace magic number 9999.0 with INFINITE_DOI constant#29alfieprojectsdev wants to merge 1 commit into
Conversation
Replaced the hardcoded 9999.0 value in balancer/core.py with a named constant INFINITE_DOI to represent infinite stock duration when daily burn rate is zero. Updated calculate_bmi and detect_imbalances to use this constant. Added unit tests in balancer/test_infinite_doi.py to verify correct behavior for zero burn rates. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR replaces the magic number
9999.0(and9999) inbalancer/core.pywith a named constantINFINITE_DOI. This improves code readability and maintainability.Changes:
INFINITE_DOI = 9999.0inbalancer/core.py.calculate_bmito returnINFINITE_DOIwhen burn rate is <= 0.detect_imbalancesto useINFINITE_DOIfordays_to_consume_locallycalculation when burn rate is <= 0.balancer/test_infinite_doi.pyto test zero burn rate scenarios and verify the constant usage..gitignoreto exclude__pycache__and other artifacts.Tests:
pytest balancer/and all tests passed, including the new tests.PR created automatically by Jules for task 1066388509181787060 started by @alfieprojectsdev