Skip to content

⚡ Optimize useInventory hook to avoid redundant toJSON calls#37

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
perf/optimize-inventory-hook-13571095521181078116
Open

⚡ Optimize useInventory hook to avoid redundant toJSON calls#37
alfieprojectsdev wants to merge 1 commit into
mainfrom
perf/optimize-inventory-hook-13571095521181078116

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

Implemented performance optimization in client/src/hooks/useInventory.ts by using RxDocument objects directly instead of converting to JSON via .toJSON() on every update.

Why:
RxDB documents are reactive and property access is fast. Converting to JSON creates new object references for every document on every update cycle, which is O(N) and triggers garbage collection. For large lists, this is a significant overhead.

Optimization:

  • Changed transactions state to RxDocument<TransactionDocType>[].
  • Removed .map(d => d.toJSON()).
  • Updated reduce logic to access properties directly (which works seamlessly as RxDocument proxies properties).

Measured Improvement:
A benchmark script with 10,000 documents showed:

  • Before (toJSON): ~20.35 ms per iteration
  • After (Direct): ~0.66 ms per iteration
  • Improvement: ~30x faster

Verification:

  • Verified manual UI functionality (Transaction Ledger renders correctly).
  • Verified TypeScript build passes.

PR created automatically by Jules for task 13571095521181078116 started by @alfieprojectsdev

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant