fix: update CLAUDE.md to replace stale dev-* Makefile targets with local-*

[mprpic]

The CRC-based dev-* targets (dev-logs, dev-start, dev-stop, etc.) were replaced with local-* equivalents in 5553056 but CLAUDE.md was never updated to reflect this.

[github-actions]

Claude Code Review

Summary

This PR correctly updates CLAUDE.md to replace the stale CRC-based dev-* Makefile targets with the current local-* targets for minikube-based development. The changes align with the migration done in commit 5553056 (PR #367) where CRC was replaced with minikube as the default local development environment.

Issues by Severity

🚫 Blocker Issues

None. This PR can be merged.

🔴 Critical Issues

Incomplete Documentation Update

• Location: Multiple documentation files across the repository
• Issue: While CLAUDE.md is updated, many other documentation files still reference the old dev-* targets
• Files affected:
  • components/README.md
  • components/manifests/README.md
  • components/frontend/README.md
  • docs/user-guide/getting-started.md
  • docs/testing/testing-summary.md
  • docs/developer/local-development/README.md
  • docs/labs/basic/lab-1-first-rfe.md
  • CONTRIBUTING.md
  • .github/workflows/README.md
  • Many files in docs/developer/local-development/crc.md (intentionally for CRC-specific instructions)
• Impact: Users following other documentation will encounter non-existent Makefile targets
• Recommendation: Create a follow-up issue/PR to update all documentation comprehensively. See pattern below:
  • Replace make dev-start → make local-up
  • Replace make dev-stop → make local-down
  • Replace make dev-clean → make local-clean
  • Replace make dev-logs → make local-logs
  • Replace make dev-test → make local-test
  • Note: docs/developer/local-development/crc.md should retain dev-* references as it documents CRC-specific setup

🟡 Major Issues

Missing kind-down in Cleanup Section

• Location: CLAUDE.md:234
• Issue: The PR adds make kind-down to the cleanup commands, which is correct and consistent with the architecture (kind is the recommended approach per line 119)
• Positive: Good addition that was missing before

Inconsistent Recommendation Hierarchy

• Location: CLAUDE.md:114-132
• Issue: Kind is marked as "Recommended" (line 114) but minikube is shown as "Alternative" with less detail
• Current state: Appropriate - kind is production-like and matches CI environment
• No action needed: Current hierarchy is correct

🔵 Minor Issues

dev-test-operator Still Exists

• Location: Makefile:17
• Issue: One dev-* target still exists in the Makefile (dev-test-operator)
• Impact: Low - it's a valid remaining target, but naming is inconsistent
• Recommendation: Consider renaming to local-test-operator for consistency in a future cleanup PR

Missing Target Descriptions

• Location: CLAUDE.md:213-238
• Issue: Some new targets lack detailed descriptions (e.g., what local-troubleshoot actually shows)
• Impact: Low - users can infer from target names
• Recommendation: Minor documentation enhancement opportunity

Positive Highlights

✅ Accurate Translation of Targets

• All dev-* → local-* mappings are correct
• Added new targets that weren't documented before (local-status, local-troubleshoot, local-rebuild)

✅ Improved Consistency

• Removed CRC-specific references (OpenShift Local, hot-reloading with dev-sync)
• Updated access URLs from https://vteam-frontend-vteam-dev.apps-crc.testing to http://localhost:8080

✅ Better Organization

• Grouped related commands (logs, rebuild, cleanup) more logically
• Added kind-down to cleanup section (was missing before)

✅ Follows Documentation Standards

• Adheres to CLAUDE.md documentation standards (prefer inline updates over new files)
• Correctly updates the master project instructions file

Recommendations

Immediate Actions (Before Merge)

None - this PR is ready to merge as-is.

Follow-Up Actions (After Merge)

1. Create comprehensive documentation cleanup PR

   • Update all remaining dev-* references in documentation files
   • Exclude docs/developer/local-development/crc.md (intentionally CRC-specific)
   • Consider using a script to find and replace consistently:

     grep -r "make dev-" --include="*.md" . | grep -v "crc.md" | cut -d: -f1 | sort -u

2. Rename remaining Makefile target

   • dev-test-operator → local-test-operator for consistency

3. Verify Makefile target existence

   • Ensure all targets mentioned in documentation actually exist in Makefile
   • Add integration test that validates documented targets exist

Priority Order

1. ✅ Merge this PR (no blockers)
2. 🔴 Update remaining documentation (critical for user experience)
3. 🔵 Rename dev-test-operator target (minor consistency improvement)

Code Quality Assessment

Documentation Quality: ⭐⭐⭐⭐☆ (4/5)

• Clear, accurate, well-organized
• Minus one star for incomplete coverage (other docs not updated)

Consistency: ⭐⭐⭐⭐⭐ (5/5)

• All changes consistent with established patterns
• Follows CLAUDE.md documentation standards

Completeness: ⭐⭐⭐☆☆ (3/5)

• CLAUDE.md is complete
• But this is only 1 of ~15 files that need updating

---

Final Verdict: ✅ APPROVE - This PR correctly updates CLAUDE.md and should be merged. The broader documentation cleanup can be addressed in a follow-up PR.

Estimated Impact: Low risk, high value. Users following CLAUDE.md will now see correct commands.

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.