Fix Horizontal breaking on large devices

[tiwiz]

Fix layouts breaking on MEDIUM horizontal windows due to a mismatch in calculation of the Height size class

Before	After

[gemini-code-assist]

Summary of Changes

Hello @tiwiz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI layout issue where the photo empty state was incorrectly displayed horizontally on large devices, leading to a suboptimal user experience. The core change involves refining the conditions under which this horizontal layout is applied, ensuring it only occurs when the window is both wide and has limited vertical space. This enhancement improves the adaptive behavior of the UI, making it more robust across diverse screen configurations.

Highlights

• Function Renaming: The isHorizontalWindow function in LayoutUtils.kt has been renamed to shouldShowHorizontalPhotoPrompt to better reflect its refined purpose.
• Refined Layout Logic: The logic for determining when to display a horizontally aligned photo prompt has been updated. It now considers not only if the window is horizontal but also if the vertical space is smaller than a medium breakpoint, preventing layout issues on large devices with ample vertical room.
• Improved Adaptive UI: The changes ensure that the photo empty state UI adapts more appropriately to various screen sizes and orientations, specifically addressing 'horizontal breaking' on larger screens.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a layout issue on large horizontal screens by refining the logic that determines when to switch to a horizontal layout for the photo prompt. The function isHorizontalWindow has been renamed to shouldShowHorizontalPhotoPrompt and its logic updated to also consider if the window height is small. While the change is functionally correct, I've found an issue with the implementation using an internal API from the androidx.window library. I've provided a suggestion to refactor it using public APIs for better long-term stability and code clarity.