Skip to content

Fix Horizontal breaking on large devices #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiwiz merged 2 commits into from
Dec 11, 2025
Merged

Fix Horizontal breaking on large devices #185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fb99f
Fix Horizontal layout
tiwiz Dec 9, 2025
c54d176
Move function to better limit its scope to the Creation flow
tiwiz Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/util/src/main/java/com/android/developers/androidify/util/LayoutUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,17 @@ fun areBothWindowDimensionsAtLeastMedium(): Boolean {
sizeClass.isWidthAtLeastBreakpoint(WindowSizeClass.WIDTH_DP_MEDIUM_LOWER_BOUND)
}

/***
* This function is useful to understand if the window is too small to show the vertically stacked
* photo empty state. It should align items horizontally only if the window is horizontal and
* if the amount of vertical space is smaller than medium
*/
@Composable
fun isHorizontalWindow(): Boolean {
fun shouldShowHorizontalPhotoPrompt(): Boolean {
val sizeClass = calculateWindowSizeClass()
return sizeClass.minWidthDp >= sizeClass.minHeightDp
val isHorizontalWindow = sizeClass.minWidthDp >= sizeClass.minHeightDp
val isHeightSmallerThanMedium = !sizeClass.isHeightAtLeastBreakpoint(WindowSizeClass.HEIGHT_DP_MEDIUM_LOWER_BOUND)
return isHorizontalWindow && isHeightSmallerThanMedium
}

/***
Expand Down
4 changes: 2 additions & 2 deletions feature/creation/src/main/java/com/android/developers/androidify/creation/PhotoPrompt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ import com.android.developers.androidify.theme.components.SecondaryOutlinedButto
import com.android.developers.androidify.theme.sharedBoundsRevealWithShapeMorph
import com.android.developers.androidify.theme.sharedBoundsWithDefaults
import com.android.developers.androidify.util.dashedRoundedRectBorder
import com.android.developers.androidify.util.isHorizontalWindow
import com.android.developers.androidify.util.shouldShowHorizontalPhotoPrompt
import com.android.developers.androidify.creation.R as CreationR

@Composable
Expand Down Expand Up @@ -171,7 +171,7 @@ private fun UploadEmptyState(
onChooseImagePress: () -> Unit,
modifier: Modifier = Modifier,
) {
if (isHorizontalWindow()) {
if (shouldShowHorizontalPhotoPrompt()) {
HorizontallyAlignedUploadEmptyState(
onCameraPressed = onCameraPressed,
onChooseImagePress = onChooseImagePress,
Expand Down