Skip to content

arch/arm,riscv/rp23xx: Silence "LOAD segment with RWX permissions" linker warnings #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

arch/arm,riscv/rp23xx: Silence "LOAD segment with RWX permissions" linker warnings #16930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arch/arm/src/rp23xx/Make.defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
include armv8-m/Make.defs

CFLAGS += -Wno-array-bounds
LDFLAGS += --no-warn-rwx-segments
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not move to Toolchain.defs

Copy link
Contributor Author

@shtirlic shtirlic Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here? nuttx/arch/arm/src/armv8-m/Toolchain.defs and nuttx/arch/risc-v/src/common/Toolchain.defs

Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuttx/arch/arm/src/common/Toolchain.defs is better. Actually, --no-warn-rwx-segments was added in this file with some condition guard, we can remove the check directly.


CHIP_CSRCS += rp23xx_idle.c
CHIP_CSRCS += rp23xx_irq.c
Expand Down
1 change: 1 addition & 0 deletions arch/risc-v/src/rp23xx-rv/Make.defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ include common/Make.defs
HEAD_ASRC = rp23xx_head.S

CFLAGS += -Wno-array-bounds
LDFLAGS += --no-warn-rwx-segments
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


CHIP_CSRCS += rp23xx_idle.c
CHIP_CSRCS += rp23xx_irq.c
Expand Down
Loading