refactor!: Migrate service s3 to reqsign-core 2.0 #6656
+425
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
added a commit
to apache/opendal-reqsign
that referenced
this pull request
Oct 13, 2025
Fix part of apache/opendal#6656 In the real world, token files may contain non-URL-safe characters. This PR handles them by trimming and encoding the tokens before sending them out. Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Member
Author
|
This PR will need the new version of reqsign to work. |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Member
Author
|
This PR is currently waiting for seanmonstar/reqwest#2837 |
Xuanwo
added a commit
to apache/opendal-reqsign
that referenced
this pull request
Oct 19, 2025
Allow apache/opendal#6656 to pass. --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** --------- Signed-off-by: Xuanwo <[email protected]>
Member
Author
|
reqsign has started a new release to address issues we met here: apache/opendal-reqsign#660 |
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Member
Author
|
Let's merge this PR in the next version of opendal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6560
Rationale for this change
Migrate to reqsign core v2.
What changes are included in this PR?
opendal now accepts
reqsign_core::ProvideCredentialChaininstead.Are there any user-facing changes?