fix(navbar): some styling + components inconsistencies

[gabotorresruiz]

SUMMARY

This PR modernizes the navigation menu implementation, and improves consistency between Menu.tsx and RightMenu.tsx

It also fixes spacing and tab inconsistencies that occurred when the navbar height changed (e.g., due to logo size or applied margins).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #7492fc

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: 6211e74..6211e74

  • superset-frontend/src/features/home/Menu.tsx
  • superset-frontend/src/features/home/RightMenu.tsx
  • superset-frontend/src/hooks/useThemeMenuItems.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/hooks/useThemeMenuItems.tsx	✅
superset-frontend/src/features/home/Menu.tsx	✅
superset-frontend/src/features/home/RightMenu.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[sadpandajoe]

Small nit, but not a blocker

[gabotorresruiz]

Small nit, but not a blocker

Hey @sadpandajoe can you please check this out --> f01d0b0

I think that's the best I can do to have that offset in one place and have it reference from all the menu popups from the navbar

[sadpandajoe]

Nice!