Cleanup: remove unused functions related connect attempts#13357
Merged
masaori335 merged 1 commit intoJul 2, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up unused / orphaned HttpTransact APIs related to origin connect retry and negative-caching behavior, reducing dead code and keeping the public/internal interface consistent with actual usage.
Changes:
- Removed the unused
HttpTransact::is_server_negative_cached()declaration and implementation. - Removed unused/unimplemented
HttpTransactmethod declarations (handle_response_from_parent_plugin,delete_server_rr_entry). - Confirmed there are no remaining references to the removed symbols in the tree.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/proxy/http/HttpTransact.cc | Removes the unused is_server_negative_cached() implementation. |
| include/proxy/http/HttpTransact.h | Removes unused / unimplemented method declarations to match available definitions and call sites. |
JosiahWI
approved these changes
Jul 2, 2026
JosiahWI
left a comment
JosiahWI
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_server_negative_cachedis not called anymorehandle_response_from_parent_pluginanddelete_server_rr_entryare declared, but no definitions.