Skip to content

Cleanup: remove unused functions related connect attempts #13357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masaori335 merged 1 commit into from
Jul 2, 2026
+0 −25
Merged

Cleanup: remove unused functions related connect attempts #13357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions include/proxy/http/HttpTransact.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,9 +1030,7 @@ class HttpTransact
static void handle_transform_ready(State *s);
static void handle_transform_cache_write(State *s);
static void handle_response_from_parent(State *s);
static void handle_response_from_parent_plugin(State *s);
static void handle_response_from_server(State *s);
static void delete_server_rr_entry(State *s, int max_retries);
static void retry_server_connection_not_open(State *s, unsigned max_retries);
static void error_log_connection_failure(State *s, ServerState_t conn_state);
static void handle_server_connection_not_open(State *s);
Expand Down Expand Up @@ -1084,7 +1082,6 @@ class HttpTransact
static void initialize_state_variables_from_request(State *s, HTTPHdr *obsolete_incoming_request);

static void initialize_state_variables_from_response(State *s, HTTPHdr *incoming_response);
static bool is_server_negative_cached(State *s);
static bool is_cache_response_returnable(State *s);
static bool is_stale_cache_response_returnable(State *s);
static bool need_to_revalidate(State *s);
Expand Down
22 changes: 0 additions & 22 deletions src/proxy/http/HttpTransact.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,28 +540,6 @@ update_cache_control_information_from_config(HttpTransact::State *s)
}
}

bool
HttpTransact::is_server_negative_cached(State *s)
{
if (s->dns_info.active && s->dns_info.active->last_fail_time() != TS_TIME_ZERO &&
s->dns_info.active->last_fail_time() + s->txn_conf->down_server_timeout > ts_clock::from_time_t(s->client_request_time)) {
return true;
} else {
// Make sure some nasty clock skew has not happened
// Use the server timeout to set an upperbound as to how far in the
// future we should tolerate bogus last failure times. This sets
// the upper bound to the time that we would ever consider a server
// down to 2*down_server_timeout
if (s->dns_info.active &&
ts_clock::from_time_t(s->client_request_time) + s->txn_conf->down_server_timeout < s->dns_info.active->last_fail_time()) {
s->dns_info.active->mark_up();
ink_assert(!"extreme clock skew");
return true;
}
return false;
}
}

/**
ATS has two configuration options controlling how many times it retries a connection attempt against origin servers.

Expand Down