fix: propagate version attr in pkl_package provider #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You need to run |
Ensure that a version passed as an attribute to `pkl_package` is correctly propagated through the provider. Previously, the pkl_package rule would propagate the initial version resolved at repo_rule fetching time, which may not match the one evaluated at build time.
sitaktif
force-pushed
the
pkl-package-version-propagate
branch
from
5a5ef20 to
775284d
Compare
Collaborator
Author
|
@KushalP thanks, fixed that, CI is green now |
Contributor
|
Thanks. Should we test this code path to prevent regressions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that a version passed as an attribute to
pkl_packageis correctly propagated through the provider. Previously, the pkl_package rule would propagate the initial version resolved at repo_rule fetching time, which may not match the one evaluated at build time.