Skip to content

fix: propagate version attr in pkl_package provider #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate version attr in pkl_package provider #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkl/private/pkl_package.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def _pkl_package_impl(ctx):
executable = pkl_toolchain.cli[DefaultInfo].files_to_run.executable

project_metadata_info = ctx.attr.project[PklMetadataInfo]
pkl_project_base_uri = project_metadata_info.base_uri
pkl_project_file = project_metadata_info.pkl_project_file
pkl_project_deps = project_metadata_info.pkl_project_deps
pkl_project_name = project_metadata_info.pkl_project_name
Expand All @@ -34,6 +35,16 @@ def _pkl_package_impl(ctx):
pkl_project_version = ctx.attr.version
extra_flags.append("--env-var=PKL_PACKAGE_VERSION={}".format(ctx.attr.version))

# The provider we pass along also needs to have the updated version.
# TODO: This API is quite awkward; change it to (only) evaluate name/version/base_uri in pkl_package instead.
project_metadata_info = PklMetadataInfo(
base_uri = pkl_project_base_uri,
pkl_project_file = pkl_project_file,
pkl_project_deps = pkl_project_deps,
pkl_project_name = pkl_project_name,
pkl_project_version = pkl_project_version,
)

artifact_prefix = "{name}@{version}".format(name = pkl_project_name, version = pkl_project_version)

metadata_file = ctx.actions.declare_file("{prefix}".format(prefix = artifact_prefix))
Expand Down