Raise FileExistsError if colabfold raw directory is found before performing colabfold alignments - #233
Merged
Conversation
…orming colabfold alignments
Contributor
Author
@qurat-ul-ain95 Could you verify that the above change to the test |
jandom
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existance of the
rawcolabfold directory, in particular, theraw/out.tar.gzfile from a previous run can cause the colabfold pipeline to assume that the colabfold job has been previously completed and skips submitting a new job.In the worst case scenario, if a previous inference job crashes, and a new one is submitted, the wrong alignments from the outdated
out.tar.gzfile will be parsed and create potentially silent issues for prediction.This PR raises an FileExistsError in the case that the colabfold raw directory still exists, and instructs the user to delete the directory. At this time, we leave the task of deleting the directory on the user in case they want to inspect or save the raw files.
Changes
preprocess_colabfold_msasadd an error if theraw/output directory existsTestColabFoldQueryRunner.test_preprocess_raises_if_raw_dir_existsto check for FileExistsErrorTestColabFoldQueryRunner.test_empty_m8_file_handling: Replace the fullpreprocess_colabfold_msascall withadd_msa_paths_to_iqs. I believe the intended purpose is to check the assignment of the templates alignments / entry ids upon receiving an empty template pdb70.m8 file. The rest ofpreprocess_colabfold_msasis already performed separately in this test in order to add additional assertions and checks.TestColabFoldQueryRunner.test_features_on_multiple_queries_with_same_name: Delete the raw directory upon completion of the test loop.Related Issues
#39
Testing
openfold3/tests/core/data/tools/test_colabfold_msa_server.pyOther Notes
rawColabfold folder before processing #39