fix(x/gov): fix logic for dynamic min deposit and min initial deposit update in UpdateParams
#243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
giuliostramondo,
jaekwon and
tbruyelle
as code owners
tbruyelle
approved these changes
Nov 20, 2025
Collaborator
Author
|
I added another bit of code that only sets the |
julienrbrt
added a commit
to atomone-hub/cosmos-sdk
that referenced
this pull request
Nov 21, 2025
tbruyelle
approved these changes
Nov 21, 2025
julienrbrt
added a commit
to atomone-hub/cosmos-sdk
that referenced
this pull request
Dec 1, 2025
* feat(x/gov): add fork protos * chore: coredao proto changes * add all logic changes except in msg server and endblocker * build * wire quorum * params + build * go mod tidy all * updates * go mod tidy * refactor: add empty checks for genesis field and fix min deposit validation * test: resolve tests * fix: bump tiems voting period extended, and quorum check queue * chore: remove deprecated rpc * test: resolve more tests * add changelog + re-add command in autocli, use correct min deposit in test * fix: re-setup cancel proposal params * test: resolve todo on min deposit tests * revert * cherry-pick atomone-hub/atomone#243 * chore: temp comment x/gov new commands * test: fix simulation randomVotingOption helper * feedback (1/n) * chore: fill in tally deprecated tally params * refactor: allow legacy query with 0 params key, fix genesis test * fix: re-add `skipMinDepositRatioCheck` (feedback 3/n) * re-add some manual cli to not update cosmossdk.io/api * test: remove no with veto option from e2e * test: fix more tests and linting * test: fix typo * test: no min deposit * test: fix sims * refactor: improve collection handling and add migrations * chore: align v1beta1 params * test: fix tally tests * fix: typo * test: total vote option e2e = 1 * test: e2e * fix: wire `NewCmdGenerateConstitutionAmendment`
Collaborator
Author
|
NOTE: this PR won't be merged due to the migration to the Waiting on #248 to be merged to close this since it should be included between atomone-hub/cosmos-sdk#17 and #248. |
Collaborator
|
This already got cherry-picked in atomone-hub/cosmos-sdk#17 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the update logic of
UpdateParamsfor the min deposit and min initial deposit where if the floor value is set to be higher than the current value, this is not reflected in the updated amounts.