Skip to content

fix(x/gov): fix logic for dynamic min deposit and min initial deposit update in UpdateParams #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giunatale wants to merge 2 commits into from
Closed

fix(x/gov): fix logic for dynamic min deposit and min initial deposit update in UpdateParams #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70dd7e
fix updateParam logic
giunatale Nov 20, 2025
d1d656a
trigger last deposit update in UpdateParams only if required
giunatale Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions x/gov/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"

"cosmossdk.io/errors"
"cosmossdk.io/math"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors1 "github.com/cosmos/cosmos-sdk/types/errors"
Expand Down Expand Up @@ -187,9 +188,16 @@ func (k msgServer) UpdateParams(goCtx context.Context, msg *v1.MsgUpdateParams)

// before params change, trigger an update of the last min deposit
minDeposit := k.GetMinDeposit(ctx)
k.SetLastMinDeposit(ctx, minDeposit, ctx.BlockTime())
newMinDeposit := v1.GetNewMinDeposit(msg.Params.MinDepositThrottler.FloorValue, minDeposit, math.LegacyOneDec())
if !minDeposit.Equal(newMinDeposit) {
k.SetLastMinDeposit(ctx, newMinDeposit, ctx.BlockTime())
}

minInitialDeposit := k.GetMinInitialDeposit(ctx)
k.SetLastMinInitialDeposit(ctx, minInitialDeposit, ctx.BlockTime())
newMinInitialDeposit := v1.GetNewMinDeposit(msg.Params.MinInitialDepositThrottler.FloorValue, minInitialDeposit, math.LegacyOneDec())
if !minInitialDeposit.Equal(newMinInitialDeposit) {
k.SetLastMinInitialDeposit(ctx, newMinInitialDeposit, ctx.BlockTime())
}

if err := k.SetParams(ctx, msg.Params); err != nil {
return nil, err
Expand Down
Loading