refactor(x/gov): use interface checks instead of type checks #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
Pantani,
giuliostramondo,
giunatale and
tbruyelle
as code owners
julienrbrt
added a commit
to atomone-hub/atomone
that referenced
this pull request
Dec 10, 2025
Pantani
reviewed
Dec 10, 2025
x/gov/keeper/proposal.go
Outdated
| for _, msg := range p.Messages { | ||
| var sdkMsg sdk.Msg | ||
| if err := keeper.cdc.UnpackAny(msg, &sdkMsg); err == nil { | ||
|
|
Collaborator
There was a problem hiding this comment.
maybe you could run make lint-fix
julienrbrt
commented
Dec 10, 2025
Pantani
approved these changes
Dec 10, 2025
Collaborator
|
Interesting fix, well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helps atomone-hub/atomone#248
This effectively loosen the checks, as any message implementing this interface will get this proposal kind.
This is on us to verify that none of our dependency adds a message with this flags (a non malicious dependency would have no reason to do that). I think the risk is acceptable. It makes the code on the atomone-hub/atomone#248 PR nicer (no need again another extra wrapper)