refactor!: create x/gov wrapper

[julienrbrt]

Create x/gov wrapper based on Atom One SDK

Closes: #242 and #244

[julienrbrt]

Looks like some e2e are failing. We shouldn't need to touch them and they should pass as is (to confirm the wrapper works seamlessly). Checking...

[tbruyelle]

@julienrbrt If possible I'd like to keep the migrations code, I think it's helpful when you need to write a new one, or when you need to refresh your mind about how one upgrade has been coded.

[julienrbrt]

@julienrbrt If possible I'd like to keep the migrations code, I think it's helpful when you need to write a new one, or when you need to refresh your mind about how one upgrade has been coded.

Because of the removal of some functions in the module, some migration (v3) do not make sense anymore and won't compile.
I could keep it committed but commented out.

EDIT: turns out i simply need more wrappers. Re-adding.

[tbruyelle]

@julienrbrt feel free to just comment the code if this is more simple. That's good for me too.

[tbruyelle]

Here is my first review, I've checked the e2e tests and the failing tests are weird, maybe that hides some problems in the wrapper. I'll have a look as well unless you already found the solution.

[julienrbrt]

Here is my first review, I've checked the e2e tests and the failing tests are weird, maybe that hides some problems in the wrapper. I'll have a look as well unless you already found the solution.

It's on my list to check. I was playing with megablock.

[tbruyelle]

@julienrbrt oh damned, one of the failing e2e test is TestCoreDAOs/coredaos_annotation, which submits a tx supposed to annotate a proposal to the proposal.Annotation field ... But since this field only exists in the atomone proto and not in the fork proto, the change is not propagated to the store... Looks like we hit a wall here...

[julienrbrt]

We actually have that field in the fork. Let me check if i missed it in the wrapper.
EDIT: fixed 2c8c523 🤦🏾‍♂️
EDIT2: fixed complete 8d74cac 🤦🏾‍♂️

[julienrbrt]

Looks like the errors are only rest errors now.

[tbruyelle]

Looks like the errors are only rest errors now.

One is 500 on query proposal, I was able to have a log:

can't convert a gov/v1 Proposal to gov/v1beta1 Proposal when amount of proposal messages not exactly one

[tbruyelle]

Great work!
e2e tests were really useful to spot the issues here ;)

[giunatale]

neat!

with this merged we will also be finally able to finalize the governors addition (once atomone-hub/cosmos-sdk#36 is merged as well) by migrating the remaining stuff from #73. Will be a relief ahahah

[julienrbrt]

e2e tests were really useful to spot the issues here ;)

100%. Thanks a lot for digging and finding this was the last missing part: atomone-hub/cosmos-sdk#37