Skip to content

Conversation

@grosser
Copy link

@grosser grosser commented Sep 12, 2025

Fixes #8176

Description

normally when turning on the capacity reservation feature suddenly all open reservations can no longer match karpenter nodes
this change allows restoring that behavior, so everything keeps working and selected nodepools can use targeted capacity reservations if they want

How was this change tested?

bring up instance with label set and see if it matches an open reservation that it did not target via capacityReservationSelectorTerms

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 20d6a29
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68c48cdbf744aa000773df6a

@jmdeal
Copy link
Contributor

jmdeal commented Sep 15, 2025

Hey @grosser, I just wanted to draw your attention to this comment I left on the original issue: #8176 (comment). Before we go this route and add a "backdoor" to use open-capacity matching, we'd want to have a stronger understanding of the use-case, why it can't be supported by our native mechanism, and what potential changes we could make to that mechanism to address that. Like I said in that comment, if there are use-cases it would be good to document them in a new issue. While I won't say we wouldn't accept this kind of change, I want to make sure we evaluate all of our options first before adding a backdoor.

@grosser
Copy link
Author

grosser commented Sep 19, 2025

#8510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using CapacityReservation feature gates blocks open capacity reservation usage

2 participants