Client side journal rendering #2080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deirn
force-pushed
the
client-side-journal
branch
from
09a9f01 to
b65127e
Compare
deirn
force-pushed
the
client-side-journal
branch
from
f116376 to
f8d30a2
Compare
deirn
force-pushed
the
client-side-journal
branch
from
e0b11c1 to
c89f9b6
Compare
deirn
force-pushed
the
client-side-journal
branch
from
9354a2c to
c3da200
Compare
deirn
force-pushed
the
client-side-journal
branch
from
bac0bb4 to
2df3825
Compare
deirn
force-pushed
the
client-side-journal
branch
from
0acaf0c to
151a21e
Compare
Member
|
This seems stale and quite far from being ready - I'll close the PR. The journal is now fetched in pages and should thus render quicker already. Rendering it in the frontend might still be an improvement (if also using some sort of virtual list), so if you want to continue on this topic, feel free to open another PR |
Author
|
I got sidetracked doing other things 😅. I mainly make this since I wanted to see the journal when I'm on mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move journal rendering to client side, making use of virtual list component.
It's able to render huge journal with 100k transactions (generated by this script) with ease, now the bottleneck is the request to the server. One solution is to use orjson instead of simplejson, which cuts it from 8 seconds to 4 seconds. Reverted the change since it breaks tests.
Close #1410
Close #1814