test: add non-empty coverage for SyncResponse and FullScanResponse

[mubashirrao1122]

This PR adds additional test coverage for SyncResponse::is_empty and
FullScanResponse::is_empty.

It verifies responses are correctly reported as non-empty when:

• a chain update is present in SyncResponse
• last_active_indices is populated in FullScanResponse

These tests complement the existing default-empty coverage and help prevent
future regressions.

Tests:

• cargo test -p bdk_core --test test_spk_client

[Copilot]

Pull request overview

Adds non-empty test coverage for SyncResponse::is_empty and FullScanResponse::is_empty to prevent regressions where meaningful response data could be misclassified as empty.

Changes:

• Add a test asserting SyncResponse is non-empty when chain_update is set.
• Add a test asserting FullScanResponse is non-empty when last_active_indices is populated.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mubashirrao1122]

Hi! First contribution here added small tests for is_empty behavior. Happy to adjust anything if needed. Thanks

[evanlinjin]

Thanks for the contribution! These tests primarily exercise the boolean composition in is_empty, which doesn't catch the kinds of bugs we'd worry about.

If you're interested in contributing test coverage, here are some suggestions off the top of my (and @oleonardolima's) head:

• Correctness of merge_chains . Recently, we just merged Add prev_blockhash validation to CheckPoint #2115 which added prev-blockhash awareness to CheckPoint. Are the test cases in merge_chains_with_prev_blockhash complete?

• Recently, there was a bug that popped up in bdk_bitcoind_rpc (fixed in fix(bitcoind_rpc): emit invalidated heights when start_height is above agreement point #2167). May be a good idea to double check the update-creation logic there and the other chain crates (bdk_electrum and bdk_esplora).

• You can also run coverage locally and see what else is missing.