implement view pages #102
Open
implement view pages #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
5 times, most recently
from
c98ca53 to
7ff5e71
Compare
| // export the necessary contexts to enable rendering | ||
| // datacore components outside the datacore plugin | ||
| // itself | ||
| get SETTINGS_CONTEXT(): typeof SETTINGS_CONTEXT { |
Owner
There was a problem hiding this comment.
I don't think I'd do it like this - it's better to expose hook functions which load this data instead (like dc.useSettings()).
src/api/local-api.tsx
Outdated
| * Primarily intended to be used with `useAsync`. | ||
| */ | ||
| public Suspend({ | ||
| loaded: loaded, |
| ); | ||
|
|
||
| // Views: DatacoreJS view. | ||
| // @ts-ignore be quiet |
Owner
|
Added comments on the auxiliary pieces. |
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
7 times, most recently
from
4c324a6 to
60e3b70
Compare
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
from
19d3049 to
8b3fd7b
Compare
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
3 times, most recently
from
8b3fd7b to
b89038f
Compare
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
9 times, most recently
from
d7523f9 to
2e9d34a
Compare
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
14 times, most recently
from
c723a25 to
565d5a2
Compare
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
from
565d5a2 to
7cd5ff4
Compare
…d `APP_CONTEXT` in the local api
…er file view (e.g., they can be dragged into the sidebar)
GamerGirlandCo
force-pushed
the
feat/view-pages
branch
from
7cd5ff4 to
f3af7a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to quote the roadmap:
each view page has its own state consisting of the following properties:
sourceType: the type of script this view will contain (ex:ts,js,jsx,tsx...)script: the actual source code for the scripttitle: the title, as displayed in the tab/view headercurrentFile: the configurable path to the current file, so that functions and hooks such asuseCurrentPathdon't chokeall of these are configurable via the view's settings page, which can be accessed via going into the three-dot menu and clicking "View configuration".
a command to create a view page has also been added to the command palette for ease of use.
as always, let me know if i should add or change anything! :)