-
Notifications
You must be signed in to change notification settings - Fork 51
implement view pages #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GamerGirlandCo
wants to merge
14
commits into
master
Choose a base branch
from
feat/view-pages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
implement view pages #102
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f470633
create a `useAsync` hook and a companion `Suspend` component
GamerGirlandCo 18fc2c2
add `loader` parameter to `useEffect` dependencies
GamerGirlandCo 7f3af3c
make `Suspend` fallback prettier
GamerGirlandCo 6586feb
update `useAsync` to be more resilient to race conditions
GamerGirlandCo 1bc568d
rewrite `useAsync` to use suspense boundaries properly
GamerGirlandCo 681d795
expose `SETTINGS_CONTEXT`, `COMPONENT_CONTEXT`, `DATACORE_CONTEXT` an…
GamerGirlandCo 9955537
add ability to create views for queries that are treated like any oth…
GamerGirlandCo 40d8467
upgrade react-select to silence typescript errors
GamerGirlandCo b004baa
re-add vim codemirror plugin
GamerGirlandCo 877f269
re-add missing autocomplete and javascript language codemirror plugins
GamerGirlandCo b42a2dc
add more dev deps to appease typescript
GamerGirlandCo 760b0ee
bring `@codemirror/view` up to date
GamerGirlandCo 92c9cdb
silence more bogus errors
GamerGirlandCo f3af7a5
move select augmentation to proper folder, re-export some things
GamerGirlandCo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ import { Datacore } from "index/datacore"; | |
| import { DateTime } from "luxon"; | ||
| import { App, Plugin, PluginSettingTab, Setting } from "obsidian"; | ||
| import { DEFAULT_SETTINGS, Settings } from "settings"; | ||
| import { DatacoreQueryView as DatacoreJSView, VIEW_TYPE_DATACOREJS } from "ui/view-page"; | ||
|
|
||
| /** @internal Reactive data engine for your Obsidian.md vault. */ | ||
| export default class DatacorePlugin extends Plugin { | ||
|
|
@@ -55,6 +56,20 @@ export default class DatacorePlugin extends Plugin { | |
| callback: async () => { | ||
| console.log("Datacore: dropping the datastore and reindexing all items."); | ||
| await this.core.reindex(); | ||
| }, | ||
| }); | ||
| // Views: DatacoreJS view. | ||
| // @ts-ignore be quiet | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why can this not be typed? |
||
| this.registerView(VIEW_TYPE_DATACOREJS, (leaf) => new DatacoreJSView(leaf, this.api)); | ||
|
|
||
| // Add a command for creating a new view page. | ||
| this.addCommand({ | ||
| id: "datacore-add-view-page", | ||
| name: "Create View Page", | ||
| callback: () => { | ||
| const newLeaf = this.app.workspace.getLeaf("tab"); | ||
| newLeaf.setViewState({ type: VIEW_TYPE_DATACOREJS, active: true }); | ||
| this.app.workspace.setActiveLeaf(newLeaf, { focus: true }); | ||
| }, | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
|
|
||
| declare module "react-select" { | ||
| import { RefAttributes, ReactElement, JSX } from "preact/compat"; | ||
| import { StateManagerAdditionalProps } from "react-select/dist/declarations/src/useStateManager"; | ||
| import { Props } from "react-select/dist/declarations/src/Select"; | ||
| import Select from "react-select/dist/declarations/src/Select"; | ||
| export * from "react-select/dist/declarations/src/types"; | ||
| declare type StateManagedPropKeys = 'inputValue' | 'menuIsOpen' | 'onChange' | 'onInputChange' | 'onMenuClose' | 'onMenuOpen' | 'value'; | ||
| declare type PublicBaseSelectProps<Option, IsMulti extends boolean, Group extends GroupBase<Option>> = JSX.LibraryManagedAttributes<typeof Select, Props<Option, IsMulti, Group>>; | ||
| declare type SelectPropsWithOptionalStateManagedProps<Option, IsMulti extends boolean, Group extends GroupBase<Option>> = Omit<PublicBaseSelectProps<Option, IsMulti, Group>, StateManagedPropKeys> & Partial<PublicBaseSelectProps<Option, IsMulti, Group>>; | ||
| export declare type StateManagerProps<Option = unknown, IsMulti extends boolean = boolean, Group extends GroupBase<Option> = GroupBase<Option>> = SelectPropsWithOptionalStateManagedProps<Option, IsMulti, Group> & StateManagerAdditionalProps<Option>; | ||
| declare const StateManagedSelect: < | ||
| Option = unknown, | ||
| IsMulti extends boolean = false, | ||
| Group extends GroupBase<Option> = GroupBase<Option> | ||
| >( | ||
| props: StateManagerProps<Option, IsMulti, Group> | ||
| ) => ReactElement; | ||
| export default StateManagedSelect; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| .dc-cm-editor .cm-gutters { | ||
| flex: 0 0 auto; | ||
| background-color: transparent; | ||
| color: var(--text-faint) !important; | ||
| border-right: none !important; | ||
| margin-inline-end: var(--file-folding-offset); | ||
| font-size: var(--font-ui-smaller); | ||
| z-index: 1; | ||
| font-variant: tabular-nums; | ||
| } | ||
| .cm-typeName { | ||
| color: var(--headers); | ||
| } | ||
| .dc-cm-editor { | ||
| padding: 1em; | ||
| border-radius: 0.5em; | ||
| border: 1px solid var(--h5-color); | ||
| } | ||
| .cm-tooltip.cm-tooltip-autocomplete { | ||
| background: var(--embed-bg); | ||
| } | ||
| .dc-cm-editor img.cm-widgetBuffer[aria-hidden="true"] { | ||
| display: none; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'd do it like this - it's better to expose hook functions which load this data instead (like
dc.useSettings()).