test: guard workspace linker_messages=allow against silent removal - #6171
Merged
Conversation
github-actions
Bot
added
tests
bug-ops
enabled auto-merge (squash)
July 12, 2026 20:31
bug-ops
force-pushed
the
fix/5961-linker-messages-guard
branch
from
July 12, 2026 20:31
a39a143 to
48624cc
Compare
Add tests/workspace_lints.rs to catch an accidental removal of workspace.lints.rust.linker_messages = "allow" on every PR. Without it, only a manual ci-non-linux.yml dispatch or a tagged release build would surface the regression, since ci.yml (the automatic PR/push gate) is Linux-only and the eh_frame linker warning this lint suppresses only fires on macOS/arm64.
bug-ops
force-pushed
the
fix/5961-linker-messages-guard
branch
from
July 12, 2026 20:32
48624cc to
e81bf04
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/workspace_lints.rs, an integration test in the rootzephbinary crate that parses rootCargo.toml(via the existingtomldependency) and assertsworkspace.lints.rust.linker_messages == "allow".Cargo.tomlpointing to the new guard test and its limitations.CHANGELOG.md.Why
PR #5960 added
linker_messages = "allow"to unblock macOS/arm64 builds against Apple ld's__eh_frame section too largewarning underbuild.warnings = "deny". That line has no automated protection:ci-non-linux.yml(which builds on macOS and would catch a regression) only runs on manualworkflow_dispatch, andci.yml(which gates every PR) is deliberately Linux-only. An accidental removal would stay green on every PR and only surface the next time someone manually dispatchesci-non-linux.ymlor cuts a tagged release.The new test closes that blind spot by checking the config value directly, so it runs on every PR via
ci.yml's Linux runners without needing a macOS machine.Closes #5961
Test plan
cargo nextest run --config-file .github/nextest.toml -p zeph -E 'test(workspace_lints)'— passescargo +nightly fmt --check— cleancargo clippy -p zeph --profile ci --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warnings— cleanlinker_messagesis changed or removed (negative-control test, reverted)