Repository navigation
fix(xdebug-trace): pid-named temp dir, remove dirs of dead processes - #412
Merged
Merged
Conversation
…at start In memory storage mode a crash or kill -9 skipped the cleanup at exit and left up to keep x max_upload of traces in the temp dir for good. The dir is now buggregator-xdebug-traces-<pid>; at start dirs whose process is gone are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #410 (base
feat/xdebug-trace-storage). From the #410 review.Problem
Memory storage mode keeps trace files in a temp dir removed at exit. A crash or
kill -9skips that, so up tokeep × max_upload(2 GB by default) stays in the temp dir for good.Fix
xdebugtrace.TempDir(base)makes<tmp>/buggregator-xdebug-traces-<pid>; at start it removes such dirs whose process is gone (and a leftover with its own pid). Dirs of live processes and other names are left alone.kill(pid, 0)on Unix (EPERM = alive),os.FindProcesson Windows.main.gouses it instead ofos.MkdirTemp.Tests
TestTempDir_RemovesDeadProcessDirs: dead child pid removed, live pid kept, own leftover emptied, other names kept.go test -race -count=1 ./modules/xdebugtrace/ok;go vetclean, alsoGOOS=windows go vet ./modules/xdebugtrace/.Made with harnsy