fix(typescript): remove spurious approve() before ERC-20 transfer#729
Merged
Conversation
✅ Heimdall Review Status
|
jazz-cb
approved these changes
Jun 18, 2026
milan-cb
approved these changes
Jun 18, 2026
ERC-20 transfer() does not require a prior approve() — that pattern is only needed for transferFrom(). The previous code called approve(recipient, amount), which granted the recipient an unintended, persistent allowance over the sender's tokens that was never consumed or revoked.
sddioulde
force-pushed
the
fix/erc20-transfer-dangling-allowance
branch
from
a6968c1 to
8ceebb1
Compare
milan-cb
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ERC-20 transfer() does not require the redundant approve call. This PR removes it.
Tests
Updated unit tests.
Also successfully tested TS example
evm/transactions/scopedAccount.transfer.ts.Checklist
A couple of things to include in your PR for completeness: