Skip to content

fix(typescript): remove spurious approve() before ERC-20 transfer #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sddioulde merged 2 commits into from
Jun 18, 2026
Merged

fix(typescript): remove spurious approve() before ERC-20 transfer #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba45f7
fix(typescript): remove spurious approve() before ERC-20 transfer
sddioulde Jun 17, 2026
8ceebb1
Add changelog
sddioulde Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions typescript/.changeset/happy-badgers-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@coinbase/cdp-sdk": patch
---

Removed erroneous call from network-scoped EVM account ERC-20 transfers
98 changes: 11 additions & 87 deletions typescript/packages/cdp-sdk/src/actions/evm/transfer/transferWithViem.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,21 +118,8 @@ describe("transferWithViem", () => {
transferArgsWithoutNetwork,
);

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(2);

// Check approve transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(1, {
account: mockAccount.address,
to: "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", // USDC address on base
data: encodeFunctionData({
abi: erc20Abi,
functionName: "approve",
args: [transferArgs.to as Address, transferArgs.amount],
}),
});

// Check transfer transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(2, {
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
expect(mockWalletClient.sendTransaction).toHaveBeenCalledWith({
account: mockAccount.address,
to: "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", // USDC address on base
data: encodeFunctionData({
Expand Down Expand Up @@ -166,21 +153,8 @@ describe("transferWithViem", () => {
transferArgsWithoutNetwork,
);

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(2);

// Check approve transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(1, {
account: mockAccount.address,
to: "0x036CbD53842c5426634e7929541eC2318f3dCF7e", // USDC address on base-sepolia
data: encodeFunctionData({
abi: erc20Abi,
functionName: "approve",
args: [transferArgs.to as Address, transferArgs.amount],
}),
});

// Check transfer transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(2, {
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
expect(mockWalletClient.sendTransaction).toHaveBeenCalledWith({
account: mockAccount.address,
to: "0x036CbD53842c5426634e7929541eC2318f3dCF7e", // USDC address on base-sepolia
data: encodeFunctionData({
Expand Down Expand Up @@ -214,21 +188,8 @@ describe("transferWithViem", () => {
transferArgsWithoutNetwork,
);

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(2);

// Check approve transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(1, {
account: mockAccount.address,
to: customTokenAddress,
data: encodeFunctionData({
abi: erc20Abi,
functionName: "approve",
args: [transferArgs.to as Address, transferArgs.amount],
}),
});

// Check transfer transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(2, {
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
expect(mockWalletClient.sendTransaction).toHaveBeenCalledWith({
account: mockAccount.address,
to: customTokenAddress,
data: encodeFunctionData({
Expand Down Expand Up @@ -269,21 +230,8 @@ describe("transferWithViem", () => {
transferArgsWithoutNetwork,
);

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(2);

// Check approve transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(1, {
account: mockAccount.address,
to: "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", // USDC address on base
data: encodeFunctionData({
abi: erc20Abi,
functionName: "approve",
args: [recipientAccount.address, transferArgs.amount],
}),
});

// Check transfer transaction
expect(mockWalletClient.sendTransaction).toHaveBeenNthCalledWith(2, {
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
expect(mockWalletClient.sendTransaction).toHaveBeenCalledWith({
account: mockAccount.address,
to: "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913", // USDC address on base
data: encodeFunctionData({
Expand Down Expand Up @@ -319,33 +267,9 @@ describe("transferWithViem", () => {
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
});

it("should throw error when approve transaction fails", async () => {
const error = new Error("Approve failed");
mockWalletClient.sendTransaction = vi.fn().mockRejectedValue(error);

const transferArgs: TransferOptions = {
to: "0x1234567890123456789012345678901234567890" as Address,
amount: parseUnits("100", 6),
token: "usdc",
network: "base",
};

const { network, ...transferArgsWithoutNetwork } = transferArgs;
await expect(
transferWithViem(mockWalletClient, mockAccount, transferArgsWithoutNetwork),
).rejects.toThrow("Approve failed");

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
});

it("should throw error when transfer transaction fails", async () => {
const approveHash = "0xapprove123" as Hex;
it("should throw error when ERC20 transfer transaction fails", async () => {
const error = new Error("Transfer failed");

mockWalletClient.sendTransaction = vi
.fn()
.mockResolvedValueOnce(approveHash)
.mockRejectedValueOnce(error);
mockWalletClient.sendTransaction = vi.fn().mockRejectedValue(error);

const transferArgs: TransferOptions = {
to: "0x1234567890123456789012345678901234567890" as Address,
Expand All @@ -359,7 +283,7 @@ describe("transferWithViem", () => {
transferWithViem(mockWalletClient, mockAccount, transferArgsWithoutNetwork),
).rejects.toThrow("Transfer failed");

expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(2);
expect(mockWalletClient.sendTransaction).toHaveBeenCalledTimes(1);
});
});

Expand Down
12 changes: 0 additions & 12 deletions typescript/packages/cdp-sdk/src/actions/evm/transfer/transferWithViem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,6 @@ export async function transferWithViem<T extends EvmAccount>(
const network = mapChainToNetwork(walletClient.chain) as Network;
const erc20Address = getErc20Address(token, network);

// First approve the transfer
await walletClient.sendTransaction({
account: from.address,
to: erc20Address,
data: encodeFunctionData({
abi: erc20Abi,
functionName: "approve",
args: [to, value],
}),
});

// Then execute the transfer
const hash = await walletClient.sendTransaction({
account: from.address,
to: erc20Address,
Expand Down
Loading