survive_disambiguator.c: handle_lightcap: early out with false when _le->length == 0 - #316
Merged
bl4ckb0ne merged 4 commits intoAug 10, 2026
Conversation
bl4ckb0ne
requested changes
Jul 13, 2026
|
|
||
| SurviveContext *ctx = so->ctx; | ||
|
|
||
| // "assert(_le->length > 0);" sometimes breaks the whole program, so instead just return success = false and go on |
Collaborator
There was a problem hiding this comment.
The comment isnt relevant anymore, the assert has been removed.
Author
There was a problem hiding this comment.
that is true. i finally removed it :)
added 3 commits
August 3, 2026 10:21
…ssert-lightelements-length-bigger-than-zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke my program flow sometimes. See #311