[NA] [BE] Video: Add Cost Tracking for Video Models #3995
+50
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds cost tracking support for video generation models (OpenAI Sora and Google Veo3). The implementation introduces video-specific pricing calculations based on video duration in seconds, extending the existing cost calculation framework.
Key Changes:
- Adds video output price field to ModelPrice record
- Implements video generation cost calculator using duration-based pricing
- Updates cost service to detect and handle video generation models
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CostServiceTest.java | Adds test coverage for video generation cost calculation using duration |
| SpanCostCalculator.java | Implements videoGenerationCost method for duration-based pricing |
| ModelPrice.java | Extends record with videoOutputPrice field |
| CostService.java | Updates model price parsing to handle video generation mode and pricing |
| ModelCostData.java | Adds fields for video pricing and mode identification |
apps/opik-backend/src/main/java/com/comet/opik/domain/cost/CostService.java
Outdated
Show resolved
Hide resolved
Contributor
Backend Tests Results 284 files 284 suites 50m 33s ⏱️ Results for commit 60cc926. |
Contributor
Collaborator
|
✅ Test environment is now available! Access Information
The deployment has completed successfully and the version has been verified. |
thiagohora
reviewed
Nov 10, 2025
| BigDecimal videoOutputPrice = Optional.ofNullable(modelCost.outputCostPerVideoPerSecond()) | ||
| .map(BigDecimal::new) | ||
| .orElse(BigDecimal.ZERO); | ||
| String mode = Optional.ofNullable(modelCost.mode()).orElse("text_generation"); |
Contributor
There was a problem hiding this comment.
Do we know the possible values here?
thiagohora
reviewed
Nov 10, 2025
Comment on lines
110
to
+121
| BiFunction<ModelPrice, Map<String, Integer>, BigDecimal> calculator = SpanCostCalculator::defaultCost; | ||
| if (cacheCreationInputTokenPrice.compareTo(BigDecimal.ZERO) > 0 | ||
| || cacheReadInputTokenPrice.compareTo(BigDecimal.ZERO) > 0) { | ||
| calculator = PROVIDERS_CACHE_COST_CALCULATOR.getOrDefault(provider, | ||
| SpanCostCalculator::textGenerationCost); | ||
| } else if (inputPrice.compareTo(BigDecimal.ZERO) > 0 || outputPrice.compareTo(BigDecimal.ZERO) > 0) { | ||
| calculator = SpanCostCalculator::textGenerationCost; | ||
| } | ||
| if ("video_generation".equalsIgnoreCase(mode) && videoOutputPrice.compareTo(BigDecimal.ZERO) > 0) { | ||
| calculator = SpanCostCalculator::videoGenerationCost; | ||
| } else | ||
| if (cacheCreationInputTokenPrice.compareTo(BigDecimal.ZERO) > 0 | ||
| || cacheReadInputTokenPrice.compareTo(BigDecimal.ZERO) > 0) { | ||
| calculator = PROVIDERS_CACHE_COST_CALCULATOR.getOrDefault(provider, | ||
| SpanCostCalculator::textGenerationCost); | ||
| } else | ||
| if (inputPrice.compareTo(BigDecimal.ZERO) > 0 || outputPrice.compareTo(BigDecimal.ZERO) > 0) { | ||
| calculator = SpanCostCalculator::textGenerationCost; | ||
| } |
Contributor
There was a problem hiding this comment.
Can we make it a factory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds cost tracking support for video generation models (OpenAI Sora and Google Veo3). The implementation introduces video-specific pricing calculations based on video duration in seconds, extending the existing cost calculation framework.
Key Changes:
Change checklist
Issues
Testing
n.a see #3993 for SDK testing to push trace for cost.
Documentation
n.a
Example