-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[NA] [BE] Video: Add Cost Tracking for Video Models #3995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincentkoc
wants to merge
12
commits into
main
Choose a base branch
from
feat/video-costtracking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+197
−10
Open
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d1a6507
Update ModelCostData.java
vincentkoc 9c16232
Update CostService.java
vincentkoc abdc514
Update ModelPrice.java
vincentkoc c547a42
Update SpanCostCalculator.java
vincentkoc aae5a7f
Create CostServiceTest.java
vincentkoc 518f3b1
fix: assume text mode if anything
vincentkoc a80bade
Update CostService.java
vincentkoc 60cc926
Merge branch 'main' into feat/video-costtracking
vincentkoc 11e8f29
fix: review changes
vincentkoc 47922dd
Merge branch 'main' into feat/video-costtracking
vincentkoc 6c92552
Update SpanCostCalculator.java
vincentkoc cc7162d
Merge branch 'feat/video-costtracking' of https://github.com/comet-ml…
vincentkoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
apps/opik-backend/src/test/java/com/comet/opik/domain/cost/CostServiceTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.comet.opik.domain.cost; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.math.BigDecimal; | ||
| import java.util.Map; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class CostServiceTest { | ||
vincentkoc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @Test | ||
| void calculateCostForVideoGenerationUsesDuration() { | ||
| BigDecimal cost = CostService.calculateCost("sora-2", "openai", | ||
| Map.of("video_duration_seconds", 4), null); | ||
|
|
||
| assertThat(cost).isEqualByComparingTo("0.4"); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.