ci: consolidate tests on github runners #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
force-pushed
the
ci-add-aarch64
branch
9 times, most recently
from
7c34450 to
9ce65b8
Compare
Regular users on github runners can't use unshare, even if present. To avoid erroring out, allow opting out of its use by using an environment variable. Signed-off-by: Sergio Lopez <[email protected]>
GitHub provides macOS runners, so use them instead of relying on cross-compiling. Signed-off-by: Sergio Lopez <[email protected]>
GitHub has linux aarch64 runners, so use them instead of relying on cross compiling. Signed-off-by: Sergio Lopez <[email protected]>
GitHub runners support nested virtualization (only on x86_64), so consolidate the integration and unit tests on them to simplify the workflows. Signed-off-by: Sergio Lopez <[email protected]>
After consolidating unit and integration tests on github runners, we no longer need to consume Cirrus-CI credits. Signed-off-by: Sergio Lopez <[email protected]>
slp
changed the title
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
jakecorrenti
approved these changes
Mar 28, 2025
Member
jakecorrenti
left a comment
jakecorrenti
left a comment
There was a problem hiding this comment.
I can't comment much on the YAML, but tests are green so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year GitHub added nested virt support on x86_64 runners, in addition to aarch64 and macOS runners. Let's make use of them to simplify and consolidate our testing infrastructure.